Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't enable caching until reviewing where it is used #33

Open
omnilord opened this issue Sep 16, 2018 · 4 comments
Open

Don't enable caching until reviewing where it is used #33

omnilord opened this issue Sep 16, 2018 · 4 comments
Labels
bug Something isn't working cleanup Clearing up unneeded stuff or updating docs

Comments

@omnilord
Copy link
Collaborator

json.cache! is not currently set to expire in several files. Ensure that caching expires if caching is enabled.

See:
https://github.com/hurricane-response/florence-api/blob/master/app/views/api/v1/shelters/index.json.jbuilder
https://github.com/hurricane-response/florence-api/blob/master/app/views/api/v1/shelters/outdated.json.jbuilder

Other files may be using this as well.

@nihonjinrxs
Copy link
Member

@omnilord can you take this one on? I feel like we should clean this up sooner rather than later.

@nihonjinrxs nihonjinrxs added bug Something isn't working cleanup Clearing up unneeded stuff or updating docs labels Oct 21, 2018
@omnilord
Copy link
Collaborator Author

@miklb Do we have usage statistics stored somewhere?

@miklb
Copy link
Contributor

miklb commented Oct 24, 2018

Only for the map site. At peak of Florence I saw ~1000 unique visits per day. I’ll see if the distribution map stats are different

@nihonjinrxs
Copy link
Member

@omnilord Does #83 review/fix any of this, or just refactor what's there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cleanup Clearing up unneeded stuff or updating docs
Projects
None yet
Development

No branches or pull requests

3 participants