-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added IE support #54
base: master
Are you sure you want to change the base?
Added IE support #54
Conversation
result.push(i) | ||
} | ||
return result | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果用创建数组的方式,就不要判断 Array.fill 了。
@@ -8,7 +8,7 @@ export const requestAnimationFrame = window.requestAnimationFrame || | |||
window.mozRequestAnimationFrame || | |||
window.msRequestAnimationFrame || | |||
window.oRequestAnimationFrame || | |||
function(func) { | |||
function (func) { | |||
return window.setTimeout(func, 1000 / 60); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不要修改不想关的内容,感觉像是 ide 自动格式化?
@@ -107,7 +107,7 @@ export default class CanvasNest { | |||
context.fillStyle = `rgba(${this.c.pointColor})`; | |||
context.fillRect(r.x - 0.5, r.y - 0.5, 1, 1); // 绘制一个宽高为1的点 | |||
// 从下一个点开始 | |||
for (i = idx + 1; i < all.length; i ++) { | |||
for (i = idx + 1; i < all.length; i++) { | |||
e = all[i]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不要修改不想关的提交
感谢 pr~~ 几个问题在 code review 中评论了,build、lib 目录不要 pr 上来~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ping @OwnedTom , could you please also add package-lock.json
to .gitignore
since it as a library we shouldn't upload package-lock.json
?
Due to some features (Array.fill, document.scrollElement) not existing in IE 11 I've added some small changes to make it functional