Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchange support #41

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Exchange support #41

wants to merge 5 commits into from

Conversation

titusz
Copy link

@titusz titusz commented Aug 20, 2017

Not sure if this is wanted but gave it a try anyway. This pull request adds optional support to fetch real-time balances from exchanges (Poloniex, Bitfinex, Bittrex). It sums together all the balances from the different configured exchanges and displays them together with your manually added balances. It is coded minimally invasive and tries to stay faithful to the hackisch code style :).

@titusz
Copy link
Author

titusz commented Aug 20, 2017

Added threading so exchange balance updates don´t freeze curses

@huwwp
Copy link
Owner

huwwp commented Aug 25, 2017

Sorry for the late reply, been very busy. One of my design goals behind cryptop was not storing any personal data beside holdings (which is fairly worthless, could be dummy data, placeholders, etc).

Then again this PR's features are optional and I think most people who generate exchange API keys would understand the risks.

I'll leave this here while I think about it, give other people a chance to weigh in.

@titusz
Copy link
Author

titusz commented Aug 25, 2017

Yes that is an important point to consider. If this is to be merged we should add a security warning about responsible handling of api-keys. Most exchanges allow you to setup read only api-keys. This will reduce risk to leaking your exchange balances. Another option would be to store the api secrets in the system keyring. For example with https://pypi.python.org/pypi/keyring . But than again if your system is compromised there is not much you can do to secure the keys. Third option would be to store the api secrets encrypted and ask for a password every time a user launches it.
Let me know if you consider merging this and you want some additional changes before doing so.

@rewtraw
Copy link

rewtraw commented Sep 1, 2017

I would like this feature, knowing the risks involved!
+1

@archienorman11
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants