-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oscars changes #46
base: master
Are you sure you want to change the base?
Oscars changes #46
Conversation
…tion is made, the wallet is also updated
…ledger not yet working
With just 1 ETH in a wallet, the program ends 'Could not parse data' when hiting the f key (switch to per-eth). With an additional coin in the wallet it works ok. Same problem with just BTC in wallet and pushing f key to per-btc. |
You're right. I didn't notice it before because I had multiple coins in my wallet. Turns out this is related to how the cryptocompare API works. If you only have BTC in your wallet and try to view your portfolio in terms of BTC, then right now data is requested using However, if you add another coin to your wallet, say ETH, then data is requested using I should write some logic to correct for this :) |
I really like the idea and the look and feel of cryptop. Decided to add a few things that I like to have myself. Never really did anything serious with Python before so it was also nice learning opportunity.
Here's a list of things I added