Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neurosky: use serialport adaptor and move driver to drivers/serial #1061

Merged

Conversation

gen2thomas
Copy link
Collaborator

@gen2thomas gen2thomas commented Feb 12, 2024

Solved issues and/or description of the change

Move Neurosky MindWave driver to the drivers/serial folder, remove the adaptor and use the serialport adaptor instead.

Additionally:

  • introduce WithName() and WithBaudRate() for serialport adaptor
  • increase test coverage

Manual test

none

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (e.g. by run make test_race)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code

If this is a new driver or adaptor:

  • I have added the name to the corresponding README.md
  • I have added an example to see how to setup and use it
  • I have checked or build at least my new example (e.g. by run make examples_check)

@gen2thomas gen2thomas force-pushed the feature/examples_serialport_driver branch 2 times, most recently from 9e7d985 to bd5b9c6 Compare February 12, 2024 15:08
@gen2thomas gen2thomas force-pushed the feature/examples_serialport_driver branch from bd5b9c6 to 40fb548 Compare February 12, 2024 15:20
@gen2thomas gen2thomas marked this pull request as ready for review February 12, 2024 15:26
@gen2thomas gen2thomas merged commit e2b710b into hybridgroup:dev Feb 12, 2024
6 checks passed
@gen2thomas gen2thomas deleted the feature/examples_serialport_driver branch February 12, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant