Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ble 0.10 #1084

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Update ble 0.10 #1084

merged 4 commits into from
Nov 5, 2024

Conversation

deadprogram
Copy link
Member

Solved issues and/or description of the change

Changes needed for compatibility with the new version of the bluetooth package.

Manual test

  • OS and Version (Win/Mac/Linux): Linux
  • Adaptor(s) and/or driver(s): Ran examples/ble_minidrone.go successfully.

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • New and existing unit tests pass locally with my changes (e.g. by run make test_race)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code

@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.39%. Comparing base (a8f47ea) to head (d7e841c).
Report is 1 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1084   +/-   ##
=======================================
  Coverage   72.39%   72.39%           
=======================================
  Files         115      115           
  Lines        8963     8963           
=======================================
  Hits         6489     6489           
  Misses       1795     1795           
  Partials      679      679           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deadprogram
Copy link
Member Author

@gen2thomas I will update this PR shortly once the new release of the TinyGo bluetooth package is completed, and then it should be good for merge.

@gen2thomas
Copy link
Collaborator

Hi @deadprogram , thanks for your work. Just give me a hint, when the PR is ready to review.

@gen2thomas gen2thomas mentioned this pull request Oct 31, 2024
5 tasks
@gen2thomas
Copy link
Collaborator

Hi @deadprogram , please can you rebase and finally switch to 0.10.

Thanks, Thomas

Signed-off-by: deadprogram <ron@hybridgroup.com>
Signed-off-by: deadprogram <ron@hybridgroup.com>
Signed-off-by: deadprogram <ron@hybridgroup.com>
Signed-off-by: deadprogram <ron@hybridgroup.com>
@deadprogram
Copy link
Member Author

Done.

@gen2thomas gen2thomas merged commit ab2cc0f into dev Nov 5, 2024
7 checks passed
@gen2thomas gen2thomas deleted the update-ble-0.10 branch November 5, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants