Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: correct all usage of ps3 joystick reads #1085

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

deadprogram
Copy link
Member

Solved issues and/or description of the change

This PR correct all usage of ps3 joystick reads, which are now int instead of int16

Manual test

  • OS and Version (Win/Mac/Linux): Linux
  • Adaptor(s) and/or driver(s): Ran examples/bleclient_minidrone_ps3.go successfully.

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • New and existing unit tests pass locally with my changes (e.g. by run make test_race)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code

…instead of int16

Signed-off-by: deadprogram <ron@hybridgroup.com>
@gen2thomas
Copy link
Collaborator

gen2thomas commented Oct 29, 2024

Hi @deadprogram , I noticed problems with CircleCI app. Do you know if this is related to our config or a problem with my account only?

@deadprogram
Copy link
Member Author

@gen2thomas I was noticing that as well. It does not show me the reason for the error, and also does not let me restart it.

Not sure what to do next here?

@gen2thomas
Copy link
Collaborator

Hi @deadprogram, for a recently created PR it is working, after removing the ssh deploy key by clicking the cross in the CircleCI app UI and afterwards "add deploy key".

But I can still not access the runnings of this PR. Maybe after the next commit it would be possible again? If not, you could try to close and create a new PR.

@gen2thomas gen2thomas self-requested a review October 31, 2024 16:29
@gen2thomas
Copy link
Collaborator

Hi @deadprogram , please can you rebase to dev - this will trigger a new run of all checks.

Thanks Thomas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants