From 398769606a9a63b0b13a1ec32a759aba11f4ba95 Mon Sep 17 00:00:00 2001 From: lou-a Date: Tue, 15 Oct 2024 14:55:30 -0400 Subject: [PATCH 1/3] Improved the _ravenpy_models.py script to be able to specify the rain snow fraction for all models, including HBVEC. --- src/xhydro/modelling/_ravenpy_models.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/xhydro/modelling/_ravenpy_models.py b/src/xhydro/modelling/_ravenpy_models.py index 5b6b6c68..1d82f1bd 100644 --- a/src/xhydro/modelling/_ravenpy_models.py +++ b/src/xhydro/modelling/_ravenpy_models.py @@ -117,7 +117,7 @@ def __init__( data_kwds=meteo_station_properties, ) ], - RainSnowFraction=rain_snow_fraction, + rain_snow_fraction=rain_snow_fraction, Evaporation=evaporation, **kwargs, ) @@ -152,9 +152,6 @@ def run(self) -> str | xr.Dataset: if "qobs" in default_emulator_config: default_emulator_config.pop("qobs") - if model_name == "HBVEC": - default_emulator_config.pop("RainSnowFraction") - self.model = getattr(ravenpy.config.emulators, model_name)( **default_emulator_config ) From 1dab9f33951915a1a209046716457b107367bf7e Mon Sep 17 00:00:00 2001 From: lou-a Date: Tue, 15 Oct 2024 15:08:54 -0400 Subject: [PATCH 2/3] Update AUTHORS.rst --- AUTHORS.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS.rst b/AUTHORS.rst index 1f935ba1..27aac9a8 100644 --- a/AUTHORS.rst +++ b/AUTHORS.rst @@ -19,3 +19,4 @@ Contributors * Richard Arsenault `@richardarsenault `_ * Francis Gravel `@mayetea `_ +* Louise Arnal `@lou-a `_ From 895f73a72c8d9ca42577a59a666c366d8eff3a0e Mon Sep 17 00:00:00 2001 From: lou-a Date: Tue, 15 Oct 2024 15:27:30 -0400 Subject: [PATCH 3/3] Update .zenodo.json --- .zenodo.json | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.zenodo.json b/.zenodo.json index 88ffd40e..854fc94b 100644 --- a/.zenodo.json +++ b/.zenodo.json @@ -21,6 +21,11 @@ "name": "Arsenault, Richard", "affiliation": "École de technologie supérieure, Montréal, Québec, Canada", "orcid": "0000-0003-2834-2750" + }, + { + "name": "Arnal, Louise", + "affiliation": "Ouranos", + "orcid": "0000-0002-0208-2324" } ], "keywords": [