Logging changes for ClientReference / associate build to TestResult :…

… null check for buildUrl (#199)
hygieia · Mar 22, 2021 · 12f0eb0 · 12f0eb0
1 parent 212f52b
commit 12f0eb0
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 13 deletions.
diff --git a/pom.xml b/pom.xml
@@ -5,7 +5,7 @@
     <artifactId>api</artifactId>
     <packaging>jar</packaging>
     <name>${project.groupId}:${project.artifactId}</name>
-    <version>3.4.8-SNAPSHOT</version>
+    <version>3.4.9-SNAPSHOT</version>
     <description>Hygieia Rest API Layer</description>
     <url>https://github.com/Hygieia/api</url>
 

diff --git a/src/main/java/com/capitalone/dashboard/service/TestResultServiceImpl.java b/src/main/java/com/capitalone/dashboard/service/TestResultServiceImpl.java
@@ -627,18 +627,20 @@ private TestResult createTestCucumber(CollectorItem collectorItem, CucumberJsonR
     }
 
     private void associateBuildToTestResult(String buildUrl, String clientReference, TestResult testResult){
-        Build build = buildRepository.findByBuildUrl(buildUrl);
-        if(Objects.nonNull(build)){
-            build.setClientReference(clientReference);
-            testResult.setBuildId(build.getId());
-            buildRepository.save(build);
-        }else{
-            Build baseBuild = new Build();
-            baseBuild.setBuildUrl(buildUrl);
-            baseBuild.setBuildStatus(BuildStatus.InProgress);
-            baseBuild.setClientReference(clientReference);
-            baseBuild = buildRepository.save(baseBuild);
-            testResult.setBuildId(baseBuild.getId());
+        if(Objects.nonNull(buildUrl)){
+            Build build = buildRepository.findByBuildUrl(buildUrl);
+            if(Objects.nonNull(build)){
+                build.setClientReference(clientReference);
+                testResult.setBuildId(build.getId());
+                buildRepository.save(build);
+            }else{
+                Build baseBuild = new Build();
+                baseBuild.setBuildUrl(buildUrl);
+                baseBuild.setBuildStatus(BuildStatus.InProgress);
+                baseBuild.setClientReference(clientReference);
+                baseBuild = buildRepository.save(baseBuild);
+                testResult.setBuildId(baseBuild.getId());
+            }
         }
     }