feat: impl Connection for TokioIo #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tottoto
reviewed
Apr 12, 2024
|
Should some document about this be needed. |
|
Thanks! Sounds reasonable to me. I left some comments. |
kvinwang
force-pushed
the
connection-tokioio
branch
from
b9e0c85
to
00354a6
Compare
tottoto
approved these changes
Apr 13, 2024
dswij
approved these changes
Apr 13, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this implementation, when a downstream crate wants to implement a custom
HttpConnector, it would have to wrap up an extra layer overTokioIo<TcpStream>. Consequently, this would result in a forwarding implementation ofhyper::rt::{Read, Write}for the new type.See here for more detail.