Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): bump tower to v0.5 #144

Closed
wants to merge 1 commit into from

Conversation

paolobarbolini
Copy link

Upgrades to the recently released tower v0.5

@paolobarbolini
Copy link
Author

Weird. tower is supposed to be Rust 1.63 but it's 1.64 🤔. Looking into it

@jplatte
Copy link

jplatte commented Sep 20, 2024

Not sure whether it's a good idea, but hyper-util could also easily vendor Oneshot to keep its current MSRV.

@jplatte
Copy link

jplatte commented Sep 20, 2024

@seanmonstar What's your preferred solution here? Worth noting that tower-rs/tower#792 would relax tower's MSRV back to 1.63, but at the cost of reverting a previous change that was made to ease maintenance.

@seanmonstar
Copy link
Member

Hm, I can just vendor Oneshot, that likely is the easiest for all the projects, and it's code is very small.

@seanmonstar
Copy link
Member

I ended up vendoring Oneshot, and no longer depend on tower, in #151.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants