Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new config to set TCP_USER_TIMEOUT #152

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

guillaumebort
Copy link
Contributor

Setting TCP keepalive is not enough to prevent dead TCP connections.

See https://blog.cloudflare.com/when-tcp-sockets-refuse-to-die/

I'm adding this to the "legacy" HTTP client because my goal is to add the setting to Tonic which is still using the HttpConnector.

Setting TCP keepalive is not enough to prevent dead TCP connections.

See https://blog.cloudflare.com/when-tcp-sockets-refuse-to-die/
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks :)

@seanmonstar seanmonstar merged commit 4dda024 into hyperium:master Oct 1, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants