feat: moved connect module to legacy #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
reviewed
Nov 16, 2023
|
Looks like the feature flags need to be adjusted. |
Moved the `connect` module to the legacy namespace to make space for new changes. Renamed legacy.rs -> client.rs and also moved to that namespace. Fixes: hyperium/hyper#3414
seanmonstar
approved these changes
Nov 16, 2023
howardjohn
added a commit
to howardjohn/hyper-util
that referenced
this pull request
Nov 16, 2023
Since hyperium#49, we cannot refer to the Error response from the client. This exposes it again
This was referenced Nov 16, 2023
seanmonstar
pushed a commit
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the
connectmodule to the legacy namespace to make space for new changes. Renamed legacy.rs -> client.rs and also moved to that namespace.Fixes: hyperium/hyper#3414