Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: port legacy client integration tests #77

Merged
merged 1 commit into from
Dec 25, 2023
Merged

feat: port legacy client integration tests #77

merged 1 commit into from
Dec 25, 2023

Conversation

dswij
Copy link
Member

@dswij dswij commented Dec 9, 2023

@dswij
Copy link
Member Author

dswij commented Dec 11, 2023

@seanmonstar would you prefer if all the tests are ported in one huge PR, or split up into multiple smaller PRs?

@seanmonstar
Copy link
Member

Either is fine to me. I have no problem merging in chunks, or if it's easier we can wait.

@dswij dswij mentioned this pull request Dec 22, 2023
Merged
@dswij dswij force-pushed the port-legacy-client-test branch 2 times, most recently from 65d8bdb to 5f00a5e Compare December 25, 2023 10:23
@dswij dswij marked this pull request as ready for review December 25, 2023 10:25
@dswij
Copy link
Member Author

dswij commented Dec 25, 2023

@seanmonstar This is ready for review.

I skipped the test for CaptureConnection since this was not ported. (from hyperium/hyper#3144)

seanmonstar
seanmonstar approved these changes Dec 25, 2023
View reviewed changes
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! 🖖

@seanmonstar seanmonstar merged commit 43ddd6d into hyperium:master Dec 25, 2023
15 checks passed
@dswij dswij deleted the port-legacy-client-test branch December 25, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dswij @seanmonstar