New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the correct default value #82

Merged

seanmonstar merged 1 commit into hyperium:master from psibi:fix-doc

Dec 21, 2023

Contributor

psibi commented Dec 21, 2023

Load testing on our web application caused issues and it looks like it is because of this.

The default value is 200 as you can see from the default instantiation here: https://github.com/hyperium/hyper/blob/1d4ff3597b8e76818c8553dbfa4234cf4208c958/src/proto/h2/server.rs#L66


          Document the correct default value

483d282

Load testing on our web application caused issues and it looks like it
is because of this.

The default value is 200 as you can see from the default instantiation
here: https://github.com/hyperium/hyper/blob/1d4ff3597b8e76818c8553dbfa4234cf4208c958/src/proto/h2/server.rs#L66

seanmonstar approved these changes

View reviewed changes

Member

seanmonstar left a comment

Ah, a place we forgot to update when setting a default. Thanks for fixing it!

seanmonstar enabled auto-merge (rebase)

December 21, 2023 17:53

seanmonstar disabled auto-merge

December 21, 2023 17:53

seanmonstar enabled auto-merge (squash)

December 21, 2023 17:54

seanmonstar merged commit 4d1ed57 into hyperium:master

15 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet