Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eclipsetestnet #121

Open
wants to merge 1 commit into
base: trevor/eclipsedevnet
Choose a base branch
from
Open

Conversation

daniel-savu
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Jan 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperlane-warp-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 6:25pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
nautilus-bridge ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2024 6:25pm
nexus-bridge ⬜️ Ignored (Inspect) Jan 22, 2024 6:25pm

@daniel-savu daniel-savu changed the base branch from main to eclipse-mainnet January 22, 2024 18:22
@daniel-savu daniel-savu changed the base branch from eclipse-mainnet to trevor/eclipsedevnet January 22, 2024 18:23
Copy link
Collaborator

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, just one question

@@ -40,40 +40,56 @@ export const chains: ChainMap<ChainMetadata & { mailbox?: Address }> = {
mailbox: 'Ge9atjAc3Ltu91VTbNpJDCjZ9CFxFyck4h3YBcTF9XPq',
},
solanatestnet: {
...chainMetadata.solanatestnet,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the destructure here? Seems like most of the solanatestnet values are the same as the SDK const?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants