Skip to content
This repository has been archived by the owner on Mar 11, 2024. It is now read-only.

[version] Update to Rust edition 2021 #224

Closed
appetrosyan opened this issue Feb 19, 2023 · 0 comments · Fixed by #225
Closed

[version] Update to Rust edition 2021 #224

appetrosyan opened this issue Feb 19, 2023 · 0 comments · Fixed by #225
Assignees
@appetrosyan
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request version A versioning issue: either an outdated dependency or an update to the Rust edition
Milestone
v1.0

Comments

@appetrosyan
Copy link
Contributor

Rust edition 2021 is out. This deprecates some backwards compatibility but enables multiple enhancements. Given that Ursa is under no obligation to be compilable on older versions of Rust (and in fact can benefit greatly from the new features), it is rational to ensure that Ursa compiles with the latest edition of Rust.

Moreover, this will ensure compatibility with newer versions of several libraries. And is needed for #223
@appetrosyan appetrosyan added enhancement New feature or request dependencies Pull requests that update a dependency file version A versioning issue: either an outdated dependency or an update to the Rust edition labels Feb 19, 2023
@appetrosyan appetrosyan added this to the v1.0 milestone Feb 19, 2023
@appetrosyan appetrosyan self-assigned this Feb 19, 2023
appetrosyan added a commit to appetrosyan/ursa that referenced this issue Feb 19, 2023
@appetrosyan
[feature] hyperledger-archives#224: Ensure Ursa compiles with Rust ed…
9dfe6e1 
…ition 2021

Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
@appetrosyan appetrosyan mentioned this issue Feb 19, 2023
Merged
appetrosyan added a commit to appetrosyan/ursa that referenced this issue Feb 19, 2023
@appetrosyan
[feature] hyperledger-archives#224: Ensure Ursa compiles with Rust ed…
30b1f08 
…ition 2021

Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/ursa that referenced this issue Feb 19, 2023
@appetrosyan
[feature] hyperledger-archives#224: Ensure Ursa compiles with Rust ed…
cb56546 
…ition 2021

Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
@appetrosyan appetrosyan pinned this issue Feb 22, 2023
ryjones pushed a commit to appetrosyan/ursa that referenced this issue Mar 16, 2023
@appetrosyan @ryjones
[feature] hyperledger-archives#224: Ensure Ursa compiles with Rust ed…
e6e3b82 
…ition 2021

Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
ryjones pushed a commit to appetrosyan/ursa that referenced this issue Apr 24, 2023
@appetrosyan @ryjones
[feature] hyperledger-archives#224: Ensure Ursa compiles with Rust ed…
0ff66e1 
…ition 2021

Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
Signed-off-by: Ry Jones <ry@linux.com>
@brentzundel brentzundel unpinned this issue Apr 24, 2023
appetrosyan added a commit to appetrosyan/ursa that referenced this issue Apr 24, 2023
@appetrosyan
[feature] hyperledger-archives#224: Ensure Ursa compiles with Rust ed…
f8943f1 
…ition 2021

Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
ryjones pushed a commit that referenced this issue Apr 24, 2023
@appetrosyan @ryjones
[feature] #224: Ensure Ursa compiles with Rust edition 2021
885acd5 
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@appetrosyan appetrosyan

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request version A versioning issue: either an outdated dependency or an update to the Rust edition
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

[feature] #224: Ursa bump to edition 2021 and trivial dependencies appetrosyan/ursa
1 participant
@appetrosyan