Skip to content

Commit

Permalink
test(connector-corda): fix deploy-cordapp-jars-to-nodes-v4.8-express
Browse files Browse the repository at this point in the history
1. Upgrading the images that were being used made it so that now the test
is no longer flaky/broken (or at least that's what a series of executions
of it made it looked like on my local machine)
2. Based on the above it might be worthwhile to put this test back into the
ones that are running (previously it was marked to be skipped).
3. We should keep an eye on it to make sure it's not flaky on the CI either
(which has resources much more constrained than my local development machine)

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
  • Loading branch information
petermetz committed Jun 27, 2024
1 parent 5abbbff commit ac6e884
Showing 1 changed file with 6 additions and 8 deletions.
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import type { AddressInfo } from "net";
import test, { Test } from "tape-promise/tape";
import { v4 as internalIpV4 } from "internal-ip";
import { v4 as uuidv4 } from "uuid";
import http from "http";
import bodyParser from "body-parser";
import express from "express";
import { AddressInfo } from "net";

import { Containers, CordaTestLedger } from "@hyperledger/cactus-test-tooling";
import {
Expand All @@ -16,6 +16,7 @@ import {
SampleCordappEnum,
CordaConnectorContainer,
} from "@hyperledger/cactus-test-tooling";
import { Configuration } from "@hyperledger/cactus-core-api";

import {
CordappDeploymentConfig,
Expand All @@ -25,26 +26,23 @@ import {
InvokeContractV1Request,
JvmTypeKind,
} from "../../../main/typescript/generated/openapi/typescript-axios/index";
import { Configuration } from "@hyperledger/cactus-core-api";

import {
IPluginLedgerConnectorCordaOptions,
PluginLedgerConnectorCorda,
} from "../../../main/typescript/plugin-ledger-connector-corda";
import { K_CACTUS_CORDA_TOTAL_TX_COUNT } from "../../../main/typescript/prometheus-exporter/metrics";

const logLevel: LogLevelDesc = "TRACE";
const logLevel: LogLevelDesc = "INFO";

// Skipping this until we figure out how to make the test case stable
// https://github.com/hyperledger/cactus/issues/1598
test.skip("Tests are passing on the JVM side", async (t: Test) => {
test("Tests are passing on the JVM side", async (t: Test) => {
test.onFailure(async () => {
await Containers.logDiagnostics({ logLevel });
});

const ledger = new CordaTestLedger({
imageName: "ghcr.io/hyperledger/cactus-corda-4-8-all-in-one-obligation",
imageVersion: "2021-08-31--feat-889",
imageVersion: "2023-11-03-86d6b38",
logLevel,
});
t.ok(ledger, "CordaTestLedger v4.8 instantaited OK");
Expand Down Expand Up @@ -111,7 +109,7 @@ test.skip("Tests are passing on the JVM side", async (t: Test) => {
const connector = new CordaConnectorContainer({
logLevel,
imageName: "ghcr.io/hyperledger/cactus-connector-corda-server",
imageVersion: "2021-11-23--feat-1493",
imageVersion: "2023-08-25-ea5522b",
envVars: [envVarSpringAppJson],
});
t.ok(CordaConnectorContainer, "CordaConnectorContainer instantiated OK");
Expand Down

0 comments on commit ac6e884

Please sign in to comment.