-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(besu): refactor jest test negative test cases #3467
Labels
Besu
enhancement
New feature or request
good-first-issue-100-introductory
P3
Priority 3: Medium
Tests
Anything related to tests be that automatic or manual, integration or unit, etc.
Comments
jagpreetsinghsasan
added
enhancement
New feature or request
Besu
Tests
Anything related to tests be that automatic or manual, integration or unit, etc.
P3
Priority 3: Medium
good-first-issue-100-introductory
labels
Aug 8, 2024
@ashnashahgrover here's the issue |
jagpreetsinghsasan
changed the title
test(plugin-besu): refactor jest test negative test cases
test(besu): refactor jest test negative test cases
Aug 8, 2024
Please assign me. |
ashnashahgrover
added a commit
to ashnashahgrover/cacti
that referenced
this issue
Aug 8, 2024
Primary Changes ---------------- 1. Refactored all negative test case exception assertions for cactus-plugin-ledger-connector-besu. Removed try-catch blocks, replaced with declarations through jest and jest-extended's own API. 2. Noted two tests within openapi-validation.test.ts (GetPastLogsEndpoint and GetBesuRecordEndpointV1 with empty parameters) where the status code returned should be 400 but is 200. This could be investigated in a seperate issue. Fixes hyperledger-cacti#3467 Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
ashnashahgrover
added a commit
to ashnashahgrover/cacti
that referenced
this issue
Aug 8, 2024
Primary Changes ---------------- 1. Refactored all negative test case exception assertions for cactus-plugin-ledger-connector-besu. Removed try-catch blocks, replaced with declarations through jest and jest-extended's own API. 2. Noted two tests within openapi-validation.test.ts (GetPastLogsEndpoint and GetBesuRecordEndpointV1 with empty parameters) where the status code returned should be 400 but is 200. This could be investigated in a seperate issue. Fixes hyperledger-cacti#3467 Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
5 tasks
|
ashnashahgrover
added a commit
to ashnashahgrover/cacti
that referenced
this issue
Aug 11, 2024
Primary Changes ---------------- 1. Refactored all negative test case exception assertions for cactus-plugin-ledger-connector-besu. Removed try-catch blocks, replaced with declarations through jest and jest-extended's own API. 2. Noted two tests within openapi-validation.test.ts (GetPastLogsEndpoint and GetBesuRecordEndpointV1 with empty parameters) where the status code returned should be 400 but is 200. This could be investigated in a seperate issue. Fixes hyperledger-cacti#3467 Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
ashnashahgrover
added a commit
to ashnashahgrover/cacti
that referenced
this issue
Aug 12, 2024
Primary Changes ---------------- 1. Refactored all negative test case exception assertions for cactus-plugin-ledger-connector-besu. Removed try-catch blocks, replaced with declarations through jest and jest-extended's own API. 2. Noted two tests within openapi-validation.test.ts (GetPastLogsEndpoint and GetBesuRecordEndpointV1 with empty parameters) where the status code returned should be 400 but is 200. This could be investigated in a seperate issue. Fixes hyperledger-cacti#3467 Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
ashnashahgrover
added a commit
to ashnashahgrover/cacti
that referenced
this issue
Aug 12, 2024
Primary Changes ---------------- 1. Refactored all negative test case exception assertions for cactus-plugin-ledger-connector-besu. Removed try-catch blocks, replaced with declarations through jest and jest-extended's own API. 2. Noted two tests within openapi-validation.test.ts (GetPastLogsEndpoint and GetBesuRecordEndpointV1 with empty parameters) where the status code returned should be 400 but is 200. This could be investigated in a seperate issue. Fixes hyperledger-cacti#3467 Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
ashnashahgrover
added a commit
to ashnashahgrover/cacti
that referenced
this issue
Aug 18, 2024
Primary Changes ---------------- 1. Refactored all negative test case exception assertions for cactus-plugin-ledger-connector-besu. Removed try-catch blocks, replaced with declarations through jest and jest-extended's own API. 2. Noted two tests within openapi-validation.test.ts (GetPastLogsEndpoint and GetBesuRecordEndpointV1 with empty parameters) where the status code returned should be 400 but is 200. This could be investigated in a seperate issue. Fixes hyperledger-cacti#3467 Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
petermetz
pushed a commit
to ashnashahgrover/cacti
that referenced
this issue
Aug 29, 2024
Primary Changes ---------------- 1. Refactored all negative test case exception assertions for cactus-plugin-ledger-connector-besu. Removed try-catch blocks, replaced with declarations through jest and jest-extended's own API. 2. Noted two tests within openapi-validation.test.ts (GetPastLogsEndpoint and GetBesuRecordEndpointV1 with empty parameters) where the status code returned should be 400 but is 200. This could be investigated in a seperate issue. Fixes hyperledger-cacti#3467 Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Besu
enhancement
New feature or request
good-first-issue-100-introductory
P3
Priority 3: Medium
Tests
Anything related to tests be that automatic or manual, integration or unit, etc.
Description
Refactor all the negative test case exception assertions for
cactus-plugin-ledger-connector-besu
so that they do not use try-catch blocks but instead declare the requirements through Jest's (and jest-extended's) own API.The parent issue with a much more detailed explanation of what's needed and code examples on how to do it:
Parent Issue: https://github.com/hyperledger/cacti/issues/3455
Acceptance Criteria
Test passes the same as before
Negative test case assertions have been migrated the way it is explained in the parent issue.
The text was updated successfully, but these errors were encountered: