-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(dast): ccp, sshconfig missing #3671
Comments
Hello Team, Please assign me this task. Thank you! Rayn |
@jagpreetsinghsasan Once you have a working fix for this (and it is merged onto main) please also make sure to set the DAST scan to be One more point: The fact that DAST starting breaking with existing configuration is pointing to the idea that maybe we accidentally created a breaking change in the Fabric connector. Could you please double check? New features should not make previously working functionality break with previously valid configuration (unless we are issuing a new major release where breaking changes are allowed). If it turns out that we did make an accidental breaking change then please open an issue to tackle that by way of investigating what can be done where the two main options are:
|
Hello @petermetz , As per my investigation, DAST on other connectors are working since there is no validation for sshConfig Here is the validation on plugin-ledger-connector-fabric: I want to know if sshConfig is a required field or not. If it is not required, maybe we can remove the validation that throws an error when there is no sshConfig. I created a PR to perform initial investigation together with the proposed solution that I am looking at to solve this issue. Cheers! |
Primary Changes ---------------- 1. Fix the issue on plugin-ledger-connector-fabric that throws an error when there is no sshConfig available. Fixes hyperledger-cacti#3671 Signed-off-by: raynato.c.pedrajeta <raynato.c.pedrajeta@accenture.com>
Primary Changes ---------------- 1. Fix the issue on plugin-ledger-connector-fabric that throws an error when there is no sshConfig available. Fixes hyperledger-cacti#3671 Signed-off-by: raynato.c.pedrajeta <raynato.c.pedrajeta@accenture.com>
Primary Changes ---------------- 1. Fix the issue on plugin-ledger-connector-fabric that throws an error when there is no sshConfig available. Fixes hyperledger-cacti#3671 Signed-off-by: raynato.c.pedrajeta <raynato.c.pedrajeta@accenture.com>
Primary Changes ---------------- 1. Fix the issue on plugin-ledger-connector-fabric that throws an error when there is no sshConfig available. Fixes hyperledger-cacti#3671 Signed-off-by: raynato.c.pedrajeta <raynato.c.pedrajeta@accenture.com>
Primary Changes ---------------- 1. Fix the issue on plugin-ledger-connector-fabric that throws an error when there is no sshConfig available. Fixes hyperledger-cacti#3671 Signed-off-by: raynato.c.pedrajeta <raynato.c.pedrajeta@accenture.com>
Primary Changes ---------------- 1. Fix the issue on plugin-ledger-connector-fabric that throws an error when there is no sshConfig available. Fixes hyperledger-cacti#3671 Signed-off-by: raynato.c.pedrajeta <raynato.c.pedrajeta@accenture.com>
@petermetz @aldousalvarez @raynatopedrajeta We have another breaking change when we added an authorization token to the cmd-api-server healthcheck endpoint in #2693 but this didn't get tested in DAST scan as DAST scan was failing due to another error (the besu aio not starting). When we fixed the besu aio error, the DAST scan started failing due to another PR (where we serialized ccp and sshconfig inputs for fabric connector) and while fixing that, we found the auth token missing for /healthcheck endpoint. So 2 points here,
|
@jagpreetsinghsasan Oh wow, nice investigation! Agreed on both points. This is also a great reminder for everyone - myself included - how easy it is to accidentally sneak in a breaking change and not even realize it for months. |
Primary Changes ---------------- 1. Fix the issue on plugin-ledger-connector-fabric that throws an error when there is no sshConfig available. Fixes hyperledger-cacti#3671 Signed-off-by: raynato.c.pedrajeta <raynato.c.pedrajeta@accenture.com>
Primary Changes ---------------- 1. Fix the issue on plugin-ledger-connector-fabric that throws an error when there is no sshConfig available. Fixes hyperledger-cacti#3671 Signed-off-by: raynato.c.pedrajeta <raynato.c.pedrajeta@accenture.com>
Primary Changes ---------------- 1. Fix the issue on plugin-ledger-connector-fabric that throws an error when there is no sshConfig available. Fixes hyperledger-cacti#3671 Signed-off-by: raynato.c.pedrajeta <raynato.c.pedrajeta@accenture.com>
Describe the bug
Due to the incorporation of #3578 task, the DAST again got broken as it now requires a sshconfig, ccp input
To Reproduce
The failing CI test can be seen in every PR at the moment
Expected behavior
The DAST scan should run without failing
Logs/Stack traces
https://github.com/hyperledger-cacti/cacti/actions/runs/12153966297/job/33892946268?pr=3659
Additional context
Adding empty
sshConfig
and connectionProfile` to this line:cacti/.github/workflows/.dast-nuclei-cmd-api-server.yaml
Line 88 in fbe68c1
The text was updated successfully, but these errors were encountered: