Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ethereum): fix broken validations in tests #3496

Closed
wants to merge 2 commits into from
Closed

test(ethereum): fix broken validations in tests #3496

wants to merge 2 commits into from

Commits on Sep 21, 2024

  1. test(ethereum): refactor jest test negative test cases 

    Primary Changes
---------------
1. Refactored negative test case exception assertions for cactus-plugin-ledger-connector-ethereum.
Removed try-catch blocks, replaced with declarations through jest-extended's own API.
2. Made comments on specific tests where the tests should fail but are actually passing
and thus cannot be refactored before being investigated further.
 
Fixes hyperledger-cacti#3475

Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
    @ashnashahgrover
    ashnashahgrover committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    438a800 View commit details
    Browse the repository at this point in the history

  2. test(ethereum): fix broken validations in tests 

    Primary Changes
---------------
1. Added code to deployContract in plugin-ledger-connector-ethereum.ts that checks if any
unexpected arguments are present, and if so throws an error.
2. Modified test on line 169 in geth-invoke-web3-method-v1.test.ts so that required argument for
invokeRawWeb3EthMethod is missing as required by the test description.

Fixes hyperledger-cacti#3487

Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
    @ashnashahgrover
    ashnashahgrover committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    b216088 View commit details
    Browse the repository at this point in the history