Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime errors don't seem to cause tests to fail #216

Open
CaptainIRS opened this issue Jul 7, 2022 · 0 comments
Open

Runtime errors don't seem to cause tests to fail #216

CaptainIRS opened this issue Jul 7, 2022 · 0 comments
Labels
bug Something isn't working build

Comments

@CaptainIRS
Copy link
Contributor

For example in https://github.com/hyperledger/caliper-benchmarks/runs/7194966698?check_suite_focus=true#step:5:3026

2022.07.05-11:18:19.096 error [caliper] [worker-message-handler] 	Error while handling "prepare" message for Worker (14245): ReferenceError: bytes is not defined
    at Object.module.exports.addBatchAssets (/home/runner/work/caliper-benchmarks/caliper-benchmarks/benchmarks/api/fabric/workloads/helper.js:69:29)
    at RangeQueryAssetWorkload.initializeWorkloadModule (/home/runner/work/caliper-benchmarks/caliper-benchmarks/benchmarks/api/fabric/workloads/rich-query-asset.js:64:26)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async CaliperWorker.prepareTest (/home/runner/work/caliper-benchmarks/caliper-benchmarks/node_modules/@hyperledger/caliper-core/lib/worker/caliper-worker.js:161:13)
    at async WorkerMessageHandler._handlePrepareMessage (/home/runner/work/caliper-benchmarks/caliper-benchmarks/node_modules/@hyperledger/caliper-core/lib/worker/worker-message-handler.js:210:13)
    at async ProcessMessenger.<anonymous> (/home/runner/work/caliper-benchmarks/caliper-benchmarks/node_modules/@hyperledger/caliper-core/lib/worker/worker-message-handler.js:89:13)

It seems to be a bug related to https://github.com/hyperledger/caliper-benchmarks/blame/main/benchmarks/api/fabric/workloads/helper.js#L7, however the tests are shown to have passed in the GitHub Actions workflow.

This issue is different from issue #211 as this issue deals with potential bugs in the caliper-benchmarks codebase.

@davidkel davidkel added bug Something isn't working build labels Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build
Projects
None yet
Development

No branches or pull requests

2 participants