Change getting started structure #2175
Conversation
[ci skip] Signed-off-by: Nikolay Yushkevich <n.yushkevich@hotmail.com>
Signed-off-by: Sara <lira.lemur@gmail.com>
| Go back to a terminal where ``irohad`` is running. You can see logs of your | ||
| transaction. | ||
|
|
||
| Congratulations! You have submitted your first transaction to Iroha. |
There was a problem hiding this comment.
Too many congratulations. Can we replace some of them with .. (idk what will be the best replacement)?
| -p 50051:50051 \ | ||
| -v $(pwd)/iroha/example:/opt/iroha_data \ | ||
| -v YOUR_PATH_TO_CONF_FILES:/opt/iroha_data \ |
There was a problem hiding this comment.
not a good idea to change that line. The reason is - the reader is not able any more do just copy-paste :(
I suggest to revert that line change and still provide an explanation in a section below.
There was a problem hiding this comment.
true - that's why I added the example below (within the instructions). I think we could leave the option of custom directory somewhere too. Maybe better to leave the previous version here and explain that a custom directory could be used instead further in the instructions?
| Here are Iroha dependancies. Python library generally consists of 3 parts: Iroha, IrohaCrypto and IrohaGrpc which we need to import: | ||
|
|
||
| .. code-block:: shell | ||
| from iroha.primitive_pb2 import can_set_my_account_detail |
There was a problem hiding this comment.
I suggest to put in a separate example, after the note, for example
There was a problem hiding this comment.
I do not understand, could you please clarify?
[ci skip]
Signed-off-by: Nikolay Yushkevich n.yushkevich@hotmail.com
Description of the Change
Benefits
Possible Drawbacks
Usage Examples or Tests [optional]
Alternate Designs [optional]