Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagating Context from Microservices: A Proposal for fabric-smart-client Improvement #599

Open
PERSEJOZA opened this issue Jun 18, 2024 · 4 comments

Comments

@PERSEJOZA
Copy link

We are implementing OpenTelemetry for observability in our solution, but we have identified a blind spot. Currently, we are unable to obtain information about delays and propagate trace information. This is due to the fact that the InitiateView method of the ViewManager does not support context propagation. As a result, we are unable to create a complete and accurate picture of the system's behavior, starting from the controller or other microservices within the solution.

We would greatly benefit from the fabric-smart-client library supporting the propagation of context instead of creating a new one. This would enable the propagation of trace information from the microservice. To achieve this, we suggest either adding a new method or modifying the existing viewManager.InitiateView() method to accept a context.

@arner
Copy link
Contributor

arner commented Jul 2, 2024

Implemented in 1564d26

@arner arner closed this as completed Jul 2, 2024
@arner
Copy link
Contributor

arner commented Aug 1, 2024

Opening this up again; another way to use FSC is to InitiateContext with a view first, and then pass around the resulting view.Context. That way should also support to derive a view.Context from an existing context.Context.

@arner arner reopened this Aug 1, 2024
@adecaro
Copy link
Contributor

adecaro commented Aug 7, 2024

@alexandrosfilios , what do you think of this?

@arner
Copy link
Contributor

arner commented Aug 7, 2024

@adecaro this is resolved if we merge #644

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants