Added note that min-block-occupancy-ratio is ignored for PoS #1354
Conversation
Signed-off-by: Anmol Sirola <95535448+AnmolSirola@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
@AnmolSirola Thanks for contributing! Can you actually make these changes to the latest version of the docs, located in the docs/ folder, instead of the 23.4.1 version? This is to make sure your changes are included when we release the latest version.
Also, can you use the Docusaurus admonition syntax for notes?
|
@alexandratran Sure, I will make changes in the latest version too. I will also use docusaurus syntax for adding the note. |
Signed-off-by: Anmol Sirola <95535448+AnmolSirola@users.noreply.github.com>
|
@alexandratran I have the required changes please have a look. |
There was a problem hiding this comment.
@AnmolSirola I still only see these changes in the versioned_docs/version-23.4.1 folder, but as I mentioned in my previous comment, you need to make the changes in the docs/ folder instead. Can you update that, or would you prefer I edit your PR myself?
Signed-off-by: Anmol Sirola <95535448+AnmolSirola@users.noreply.github.com>
|
@alexandratran I would like to apologize for my previous mistake. I misunderstood your instructions and implemented incorrect changes. However, I have now rectified the situation and made the necessary adjustments accordingly. |
versioned_docs/version-23.4.1/public-networks/reference/cli/options.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Alexandra Tran Carrillo <12214231+alexandratran@users.noreply.github.com>
Added a note in the min-block-occupancy-ratio section that it is ignored for PoS.
Issue #1344