From d5724d483db3fabb68607b6d6e1e5c442c26eb32 Mon Sep 17 00:00:00 2001 From: Anmol Sirola <95535448+AnmolSirola@users.noreply.github.com> Date: Sat, 1 Jul 2023 18:53:35 +0530 Subject: [PATCH 1/4] Add note that min-block-occupancy-ratio is ignored for PoS Signed-off-by: Anmol Sirola <95535448+AnmolSirola@users.noreply.github.com> --- .../version-23.4.1/public-networks/reference/cli/options.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/versioned_docs/version-23.4.1/public-networks/reference/cli/options.md b/versioned_docs/version-23.4.1/public-networks/reference/cli/options.md index 63a2367a32e..47eaa7787dd 100644 --- a/versioned_docs/version-23.4.1/public-networks/reference/cli/options.md +++ b/versioned_docs/version-23.4.1/public-networks/reference/cli/options.md @@ -1569,6 +1569,8 @@ min-block-occupancy-ratio="0.5" Minimum occupancy ratio for a mined block if the transaction pool is not empty. When filling a block during mining, the occupancy ratio indicates the threshold at which the node stops waiting for smaller transactions to fill the remaining space. The default is 0.8. +**Note**: The `--min-block-occupancy-ratio` option is currently ignored for PoS (Proof of Stake) networks in Hyperledger Besu. This means that setting this option will not have any effect when running Besu with a PoS consensus mechanism. + ### `miner-coinbase` From 8e9166db7b1deb3181c29f44fa47b4c0228e821b Mon Sep 17 00:00:00 2001 From: Anmol Sirola <95535448+AnmolSirola@users.noreply.github.com> Date: Tue, 4 Jul 2023 09:13:38 +0530 Subject: [PATCH 2/4] Updated options.md Signed-off-by: Anmol Sirola <95535448+AnmolSirola@users.noreply.github.com> --- .../public-networks/reference/cli/options.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/versioned_docs/version-23.4.1/public-networks/reference/cli/options.md b/versioned_docs/version-23.4.1/public-networks/reference/cli/options.md index 47eaa7787dd..d2642d8eae8 100644 --- a/versioned_docs/version-23.4.1/public-networks/reference/cli/options.md +++ b/versioned_docs/version-23.4.1/public-networks/reference/cli/options.md @@ -1569,7 +1569,12 @@ min-block-occupancy-ratio="0.5" Minimum occupancy ratio for a mined block if the transaction pool is not empty. When filling a block during mining, the occupancy ratio indicates the threshold at which the node stops waiting for smaller transactions to fill the remaining space. The default is 0.8. -**Note**: The `--min-block-occupancy-ratio` option is currently ignored for PoS (Proof of Stake) networks in Hyperledger Besu. This means that setting this option will not have any effect when running Besu with a PoS consensus mechanism. +:::note + +The `--min-block-occupancy-ratio` option is currently ignored for PoS (Proof of Stake) networks in Hyperledger Besu. This means that setting this option will not have any effect when running Besu with a PoS consensus mechanism. + +::: + ### `miner-coinbase` From acb9cb103ac53d6828996f6dc4c18a62d8b1cc29 Mon Sep 17 00:00:00 2001 From: Anmol Sirola <95535448+AnmolSirola@users.noreply.github.com> Date: Wed, 5 Jul 2023 17:50:52 +0530 Subject: [PATCH 3/4] Updated options.md in docs. Signed-off-by: Anmol Sirola <95535448+AnmolSirola@users.noreply.github.com> --- docs/public-networks/reference/cli/options.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/docs/public-networks/reference/cli/options.md b/docs/public-networks/reference/cli/options.md index 63a2367a32e..b8beb906d1d 100644 --- a/docs/public-networks/reference/cli/options.md +++ b/docs/public-networks/reference/cli/options.md @@ -1569,6 +1569,12 @@ min-block-occupancy-ratio="0.5" Minimum occupancy ratio for a mined block if the transaction pool is not empty. When filling a block during mining, the occupancy ratio indicates the threshold at which the node stops waiting for smaller transactions to fill the remaining space. The default is 0.8. +:::note + +The `--min-block-occupancy-ratio` option is currently ignored for PoS (Proof of Stake) networks in Hyperledger Besu. This means that setting this option will not have any effect when running Besu with a PoS consensus mechanism. + +::: + ### `miner-coinbase` From f5cee8a771fa94c899e960a98373b0a2f9862e43 Mon Sep 17 00:00:00 2001 From: Alexandra Tran Carrillo <12214231+alexandratran@users.noreply.github.com> Date: Wed, 5 Jul 2023 13:15:55 -0700 Subject: [PATCH 4/4] Apply suggestions from code review Signed-off-by: Alexandra Tran Carrillo <12214231+alexandratran@users.noreply.github.com> --- docs/public-networks/reference/cli/options.md | 2 +- .../version-23.4.1/public-networks/reference/cli/options.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/public-networks/reference/cli/options.md b/docs/public-networks/reference/cli/options.md index b8beb906d1d..d039d13f418 100644 --- a/docs/public-networks/reference/cli/options.md +++ b/docs/public-networks/reference/cli/options.md @@ -1571,7 +1571,7 @@ Minimum occupancy ratio for a mined block if the transaction pool is not empty. :::note -The `--min-block-occupancy-ratio` option is currently ignored for PoS (Proof of Stake) networks in Hyperledger Besu. This means that setting this option will not have any effect when running Besu with a PoS consensus mechanism. +Besu ignores the `--min-block-occupancy-ratio` option for proof of stake networks (for example, Mainnet). ::: diff --git a/versioned_docs/version-23.4.1/public-networks/reference/cli/options.md b/versioned_docs/version-23.4.1/public-networks/reference/cli/options.md index d2642d8eae8..9046d56e893 100644 --- a/versioned_docs/version-23.4.1/public-networks/reference/cli/options.md +++ b/versioned_docs/version-23.4.1/public-networks/reference/cli/options.md @@ -1571,7 +1571,7 @@ Minimum occupancy ratio for a mined block if the transaction pool is not empty. :::note -The `--min-block-occupancy-ratio` option is currently ignored for PoS (Proof of Stake) networks in Hyperledger Besu. This means that setting this option will not have any effect when running Besu with a PoS consensus mechanism. +Besu ignores the `--min-block-occupancy-ratio` option for proof of stake networks (for example, Mainnet). :::