Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added note that min-block-occupancy-ratio is ignored for PoS #1354

Merged
merged 4 commits into from
Jul 5, 2023
Merged

Added note that min-block-occupancy-ratio is ignored for PoS #1354

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d5724d4
Add note that min-block-occupancy-ratio is ignored for PoS
AnmolSirola Jul 1, 2023
8e9166d
Updated options.md
AnmolSirola Jul 4, 2023
acb9cb1
Updated options.md in docs.
AnmolSirola Jul 5, 2023
f5cee8a
Apply suggestions from code review
alexandratran Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/public-networks/reference/cli/options.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1569,6 +1569,12 @@ min-block-occupancy-ratio="0.5"

Minimum occupancy ratio for a mined block if the transaction pool is not empty. When filling a block during mining, the occupancy ratio indicates the threshold at which the node stops waiting for smaller transactions to fill the remaining space. The default is 0.8.

:::note

The `--min-block-occupancy-ratio` option is currently ignored for PoS (Proof of Stake) networks in Hyperledger Besu. This means that setting this option will not have any effect when running Besu with a PoS consensus mechanism.
alexandratran marked this conversation as resolved.
Show resolved Hide resolved

:::

### `miner-coinbase`

<!--tabs-->
Expand Down
7 changes: 7 additions & 0 deletions versioned_docs/version-23.4.1/public-networks/reference/cli/options.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1569,6 +1569,13 @@ min-block-occupancy-ratio="0.5"

Minimum occupancy ratio for a mined block if the transaction pool is not empty. When filling a block during mining, the occupancy ratio indicates the threshold at which the node stops waiting for smaller transactions to fill the remaining space. The default is 0.8.

:::note

The `--min-block-occupancy-ratio` option is currently ignored for PoS (Proof of Stake) networks in Hyperledger Besu. This means that setting this option will not have any effect when running Besu with a PoS consensus mechanism.
alexandratran marked this conversation as resolved.
Show resolved Hide resolved

:::


### `miner-coinbase`

<!--tabs-->
Expand Down