test: refactor jest test negative test cases - phase 1 #3488
Conversation
ashnashahgrover
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
|
Should I make a issue to investigate the inconsistencies in deploy-contract-from-json-xdai.test.ts and make this issue dependent on that? |
There was a problem hiding this comment.
@jagpreetsinghsasan
Should I make a issue to investigate the inconsistencies in deploy-contract-from-json-xdai.test.ts and make this issue dependent on that?
@ashnashahgrover Yes please! It's looking good in general but we need to make sure the test assertions are working as intended (and if we found an underlying bug then first we have to fix those in order to be able to prove that the asesrtions themselves work as intended)
packages/cactus-verifier-client/src/test/typescript/unit/verifier-factory.test.ts
Outdated
Show resolved
Hide resolved
ashnashahgrover
force-pushed
the
ashnashahgrover/issue3483
branch
from
947d28a
to
44ebecf
Compare
ashnashahgrover
force-pushed
the
ashnashahgrover/issue3483
branch
from
44ebecf
to
31c3426
Compare
ashnashahgrover
force-pushed
the
ashnashahgrover/issue3483
branch
from
31c3426
to
69ce435
Compare
Primary Changes --------------- 1. Refactored all remaining negative test case exception assertions under cacti/packages Removed try-catch blocks, replaced with declarations through jest-extended's own API. Fixes hyperledger-cacti#3483 Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
petermetz
force-pushed
the
ashnashahgrover/issue3483
branch
from
69ce435
to
af7dc0b
Compare
|
Closing this due to inactivity, please feel free to re-open anytime if/when bandwidth is available to take it to the finish line (some of the checks are failing such as the linter) |
Commit to be reviewed
test: refactor jest test negative test cases - phase 1
Fixes #3483