Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable table row selection #571

Merged
merged 2 commits into from
Oct 21, 2023

Conversation

xichen1
Copy link
Member

@xichen1 xichen1 commented Oct 17, 2023

Add a prop option in StandardTable component to disable the
row selection in the table.

This is to simplify the table UI and will be used for some tables
of chaincode's sub-page.

To disable the selection, add a disableSelect prop to the Stand-
ardTable component.

Signed-off-by: xichen1 xichen.pan@gmail.com

Add a prop option in StandardTable component to disable the
row selection in the table.

This is to simplify the table UI and will be used for some tables
of chaincode's sub-page.

To disable the selection, add a `disableSelect` prop to the Stand-
ardTable component.

Signed-off-by: xichen1 <xichen.pan@gmail.com>
@xichen1 xichen1 requested a review from a team October 17, 2023 08:54
Signed-off-by: xichen1 <xichen.pan@gmail.com>
@xichen1 xichen1 changed the title Add option to disable table selection Add option to disable table row selection Oct 17, 2023
Copy link
Collaborator

@fengyangsy fengyangsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@fengyangsy fengyangsy merged commit dfb7858 into hyperledger:main Oct 21, 2023
3 checks passed
@xichen1
Copy link
Member Author

xichen1 commented Oct 21, 2023

This pr is required by the Chaincode commit popup window. It can also be applied to the other main pages of the dashboard( such as org, node, channel ...)

image

@xichen1 xichen1 deleted the pureStandardTable branch November 3, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants