-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix Cache Mismatch by Deep Copying Operation #1561
Conversation
@awrichar Could you take a look at this one? |
e0cbd77
to
0eadc21
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1561 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 325 325
Lines 24049 24109 +60
=========================================
+ Hits 24049 24109 +60 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just needs that coverage bumped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just waiting on code coverage to be 100%
Signed-off-by: dwertent <david.wertenteil@kaleido.io>
0eadc21
to
2075473
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added a deep copy of the operation object to prevent ID overwriting issues. Read more here.
Fixes #1310