Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix Cache Mismatch by Deep Copying Operation #1561

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

dwertent
Copy link
Contributor

Added a deep copy of the operation object to prevent ID overwriting issues. Read more here.

Fixes #1310

@dwertent dwertent requested a review from a team as a code owner August 19, 2024 20:54
@EnriqueL8
Copy link
Contributor

@awrichar Could you take a look at this one?

pkg/core/operation.go Outdated Show resolved Hide resolved
pkg/core/operation_test.go Show resolved Hide resolved
pkg/core/operation_test.go Outdated Show resolved Hide resolved
pkg/core/operation_test.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (aeec387) to head (2075473).
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1561   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          325       325           
  Lines        24049     24109   +60     
=========================================
+ Hits         24049     24109   +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just needs that coverage bumped

Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just waiting on code coverage to be 100%

Signed-off-by: dwertent <david.wertenteil@kaleido.io>
Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EnriqueL8 EnriqueL8 merged commit 86c52e8 into hyperledger:main Sep 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retried operations pollute the cache with incorrect values
2 participants