-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: get latest tag #1570
fix: get latest tag #1570
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1570 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 325 325
Lines 24055 24055
=========================================
Hits 24055 24055 ☔ View full report in Codecov by Sentry. |
@@ -5,36 +5,25 @@ on: | |||
types: [released, prereleased] | |||
|
|||
jobs: | |||
fetch-latest-tag: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why we need this change as the fix was for the docs workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made this change because I was using ::set-output
, which is deprecated. Since I was already updating the code, I decided to align the implementation with docs.yaml
for consistency. In the future, I could move both implementations to a separate file so they can call the same job, but for now, I wanted to ensure they are consistent
Signed-off-by: dwertent <david.wertenteil@kaleido.io>
0319723
to
9e449ef
Compare
I added some minor changes to the Dockerfile based on these warnings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
set-output