Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get latest tag #1570

Merged
merged 1 commit into from
Sep 11, 2024
Merged

fix: get latest tag #1570

merged 1 commit into from
Sep 11, 2024

Conversation

dwertent
Copy link
Contributor

@dwertent dwertent commented Sep 6, 2024

  • Fixing this error
  • Using ENV instead of the deprecated set-output

@dwertent dwertent requested a review from a team as a code owner September 6, 2024 15:15
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4f64fd9) to head (9e449ef).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1570   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          325       325           
  Lines        24055     24055           
=========================================
  Hits         24055     24055           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/docs.yml Outdated Show resolved Hide resolved
.github/workflows/docs.yml Outdated Show resolved Hide resolved
@@ -5,36 +5,25 @@ on:
types: [released, prereleased]

jobs:
fetch-latest-tag:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why we need this change as the fix was for the docs workflow

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made this change because I was using ::set-output, which is deprecated. Since I was already updating the code, I decided to align the implementation with docs.yaml for consistency. In the future, I could move both implementations to a separate file so they can call the same job, but for now, I wanted to ensure they are consistent

Signed-off-by: dwertent <david.wertenteil@kaleido.io>
@dwertent
Copy link
Contributor Author

I added some minor changes to the Dockerfile based on these warnings

Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@EnriqueL8 EnriqueL8 merged commit 092a400 into hyperledger:main Sep 11, 2024
17 checks passed
@dwertent dwertent deleted the latest-tag branch September 11, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants