Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Go 1.22 #1573

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Upgrade to Go 1.22 #1573

merged 2 commits into from
Sep 12, 2024

Conversation

matthew1001
Copy link
Contributor

@matthew1001 matthew1001 commented Sep 11, 2024

All FireFly Go modules are being upgraded to Go 1.22. This PR updates Firefly itself, along with miscellaneous docs references.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.75%. Comparing base (092a400) to head (0254cf5).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main    #1573      +/-   ##
===========================================
- Coverage   100.00%   99.75%   -0.25%     
===========================================
  Files          325      338      +13     
  Lines        24055    24169     +114     
===========================================
+ Hits         24055    24110      +55     
- Misses           0       58      +58     
- Partials         0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dwertent dwertent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good just that docs doesn't make sense

@@ -103,4 +103,4 @@ Prior to FireFly v1.3.0, when the FabConnect client indexed events submitted by

### Go version upgrade

FireFly v1.3.0 now uses Go 1.21 across all modules.
FireFly v1.3.2 now uses Go 1.22 across all modules.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have release notes for v1.3.2 separate to this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reverted it under the latest commit, but given that it is a 1.3 migration guide perhaps it's worth having a sentence for both in the docs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you migrate straight to 1.3.2 the docs aren't going to give you useful/accurate information

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was thinking we have a whole page for v1.3.2 to explain the numbers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just raised #1577 to describe the numbers in the FFBigInt section. Do you think 1.3.2 needs its own migration section? I think the large number support is really just a bug fix i.e. nobody should need to take any action when they migrate, so I was assuming we'd just update the reference section of the docs (as per PR 1577) but not mention as a new feature particuarly.

Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - codecov is doing some weird

@EnriqueL8 EnriqueL8 merged commit 56fb54d into hyperledger:main Sep 12, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants