Update ffcommon, ffsigner, ffevmconnect #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
EnriqueL8
reviewed
Sep 13, 2024
| "tag": "v1.3.17", | ||
| "sha": "0fb12537b8be4fb463df713ed541aa03e2da42c582cc4c9e822f7c59a6962fef" | ||
| "tag": "v1.3.18", | ||
| "sha": "11a782c778227d198c0bff2fc94ad7e52ceea5a9994728ba05e781541680c32d" | ||
| }, | ||
| "fabconnect": { | ||
| "image": "ghcr.io/hyperledger/firefly-fabconnect", |
There was a problem hiding this comment.
Probably need to update common here? I bet it has the same problem with JSON Numbers
There was a problem hiding this comment.
I don't think common is in the manifest list?
EnriqueL8
reviewed
Sep 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1579 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 338 338
Lines 24223 24223
=======================================
Hits 24164 24164
Misses 58 58
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Yes to tezos - I'll do that now. Fabconnect doesn't pull in |
|
Going to update the manifest with Tezos and Fabric at another point when we release a new rc |
EnriqueL8
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in a fix in
firefly-commonrelated to large number handling, and updates the other related dependencies and manifest list