fix: task dependency #167
Closed
fix: task dependency #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed Moussa <ahmed.moussa@iohk.io>
hamada147
requested review from
elribonazo,
goncalo-frade-iohk,
yshyn-iohk,
curtis-h,
cristianIOHK and
amagyar-iohk
as code owners
curtis-h
approved these changes
May 23, 2024
Signed-off-by: Ahmed Moussa <ahmed.moussa@iohk.io>
Code Coverage
|
…using `cross` to build `rust` binaries Signed-off-by: Ahmed Moussa <ahmed.moussa@iohk.io>
Signed-off-by: Ahmed Moussa <ahmed.moussa@iohk.io>
Signed-off-by: Ahmed Moussa <ahmed.moussa@iohk.io>
Signed-off-by: Ahmed Moussa <ahmed.moussa@iohk.io>
Signed-off-by: Ahmed Moussa <ahmed.moussa@iohk.io>
Signed-off-by: Ahmed Moussa <ahmed.moussa@iohk.io>
Signed-off-by: Ahmed Moussa <ahmed.moussa@iohk.io>
|
The changes look good, but would be good to change the description to something that describes the work done. |
|
@cristianIOHK this was just a test for the CI runners to fix something. We can ignore it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Summarize the changes you're submitting in a few sentences, including Jira ticket ATL-xxxx if applicable. Link to any discussion, related issues and bug reports to give the context to help the reviewer understand the PR.
Alternatives Considered (optional):
Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas.
Checklist: