Skip to content

Commit

Permalink
chore: pr cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
Pat Losoponkul committed Apr 3, 2024
1 parent ec7a536 commit e5f7bea
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class WalletManagementServiceImpl(
.flatMap { case (bytes, _) =>
ZIO
.fromEither(WalletSeed.fromByteArray(bytes))
.orDieWith(msg => Exception(s"Wallet seed generatio failed: $msg"))
.orDieWith(msg => Exception(s"Wallet seed generation failed: $msg"))
}
)(ZIO.succeed)
createdWallet <- nonSecretStorage
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ object ApolloSpec extends ZIOSpecDefault {
suite("Apollo - KMP implementation")(tests: _*).provideLayer(Apollo.layer)
}

private val publicKeySpec = suite("ECPublicKey")(
private val publicKeySpec = suite("Secp256k1PublicKey")(
test("same public key bytes must be equal and have same hashCode") {
for {
apollo <- ZIO.service[Apollo]
Expand Down Expand Up @@ -81,7 +81,7 @@ object ApolloSpec extends ZIOSpecDefault {
}
)

private val privateKeySpec = suite("ECPrivateKey")(
private val privateKeySpec = suite("Secp256k1PrivateKey")(
test("same private key bytes must be equal and have same hashCode") {
for {
apollo <- ZIO.service[Apollo]
Expand Down Expand Up @@ -203,7 +203,7 @@ object ApolloSpec extends ZIOSpecDefault {
)

// FIXME: Uncomment tests when KMP apollo supports BIP32 fully
// KMP apollo only supports both hardened derivation path
// KMP apollo only supports hardened derivation path
// https://github.com/input-output-hk/atala-prism-apollo/blob/4b9b2079690093f25922da1f660c27ffcb718c08/apollo/src/commonMain/kotlin/io/iohk/atala/prism/apollo/derivation/HDKey.kt#L176
// 1. tests with normal path are commented out
// 2. TestVector1 is skipped since KMP apollo only accepts 64 bytes seed
Expand Down

0 comments on commit e5f7bea

Please sign in to comment.