Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update ConnectionEndpoints.scala #888

Merged
merged 2 commits into from
Feb 9, 2024
Merged

docs: Update ConnectionEndpoints.scala #888

merged 2 commits into from
Feb 9, 2024

Conversation

petevielhaber
Copy link
Contributor

@petevielhaber petevielhaber commented Feb 7, 2024 •
edited by mkbreuningIOHK
Loading

  • Made minor edits for consistency

Overview

Fixes ATL-6269

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@petevielhaber
Update ConnectionEndpoints.scala
fcf8d0a 
- Made minor edits for consistency

Signed-off-by: Pete Vielhaber <peter.vielhaber@iohk.io>
@petevielhaber petevielhaber changed the title Update ConnectionEndpoints.scala docs: Update ConnectionEndpoints.scala Feb 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024 •
edited
Loading

Integration Test Results

12 files  ±0  12 suites  ±0   2s ⏱️ ±0s
25 tests ±0  25 ✅ ±0  0 💤 ±0  0 ❌ ±0 
26 runs  ±0  26 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0ef57d6. ± Comparison against base commit 687d220.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024 •
edited
Loading

Unit Test Results

 86 files  ±0   86 suites  ±0   19m 39s ⏱️ -18s
725 tests ±0  717 ✅ ±0  8 💤 ±0  0 ❌ ±0 
731 runs  ±0  723 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 0ef57d6. ± Comparison against base commit 687d220.

♻️ This comment has been updated with latest results.

bvoiturier
bvoiturier approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@bvoiturier bvoiturier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @petevielhaber!

@mkbreuningIOHK
Copy link
Contributor

@bvoiturier @yshyn-iohk , is it possible to merge as @petevielhaber is out of office until 14-Feb?

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bvoiturier bvoiturier merged commit a512a60 into main Feb 9, 2024
11 checks passed
@bvoiturier bvoiturier deleted the docs-consistency-ConnectionEndpoints branch February 9, 2024 08:49
shotexa pushed a commit that referenced this pull request Mar 6, 2024
@petevielhaber @bvoiturier
docs: Update ConnectionEndpoints.scala (#888)
4191a9b 
Signed-off-by: Pete Vielhaber <peter.vielhaber@iohk.io>
Co-authored-by: bvoiturier <benjamin.voiturier@iohk.io>
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa pushed a commit that referenced this pull request Mar 6, 2024
@petevielhaber @bvoiturier
docs: Update ConnectionEndpoints.scala (#888)
7a4377a 
Signed-off-by: Pete Vielhaber <peter.vielhaber@iohk.io>
Co-authored-by: bvoiturier <benjamin.voiturier@iohk.io>
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
@petevielhaber @bvoiturier
docs: Update ConnectionEndpoints.scala (#888)
28e911b 
Signed-off-by: Pete Vielhaber <peter.vielhaber@iohk.io>
Co-authored-by: bvoiturier <benjamin.voiturier@iohk.io>
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
@petevielhaber @bvoiturier
docs: Update ConnectionEndpoints.scala (#888)
19271fd 
Signed-off-by: Pete Vielhaber <peter.vielhaber@iohk.io>
Co-authored-by: bvoiturier <benjamin.voiturier@iohk.io>
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
@petevielhaber @bvoiturier
docs: Update ConnectionEndpoints.scala (#888)
ec05220 
Signed-off-by: Pete Vielhaber <peter.vielhaber@iohk.io>
Co-authored-by: bvoiturier <benjamin.voiturier@iohk.io>
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yshyn-iohk yshyn-iohk yshyn-iohk approved these changes

@bvoiturier bvoiturier bvoiturier approved these changes

@patlo-iog patlo-iog Awaiting requested review from patlo-iog

Assignees
No one assigned
Labels
prism-agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@petevielhaber @mkbreuningIOHK @bvoiturier @yshyn-iohk @atala-dev