Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update DIDEndpoints.scala #889

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Conversation

petevielhaber
Copy link
Contributor

@petevielhaber petevielhaber commented Feb 7, 2024

  • Minor update for consistency

Overview

Fixes ATL-6271

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

- Minor update for consistency

Signed-off-by: Pete Vielhaber <peter.vielhaber@iohk.io>
Copy link
Contributor

github-actions bot commented Feb 7, 2024

Integration Test Results

12 files  ±0  12 suites  ±0   2s ⏱️ ±0s
25 tests ±0  25 ✅ ±0  0 💤 ±0  0 ❌ ±0 
26 runs  ±0  26 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a685790. ± Comparison against base commit 582483b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Unit Test Results

 86 files  ±0   86 suites  ±0   19m 46s ⏱️ -14s
725 tests ±0  717 ✅ ±0  8 💤 ±0  0 ❌ ±0 
731 runs  ±0  723 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit a685790. ± Comparison against base commit 582483b.

♻️ This comment has been updated with latest results.

Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mkbreuningIOHK
Copy link
Contributor

@bvoiturier @yshyn-iohk , is it possible to merge as @petevielhaber is out of office until 14-Feb?

@patlo-iog patlo-iog merged commit 687d220 into main Feb 9, 2024
11 checks passed
@patlo-iog patlo-iog deleted the docs-consistency-DIDEndpoints branch February 9, 2024 06:55
shotexa pushed a commit that referenced this pull request Mar 6, 2024
Signed-off-by: Pete Vielhaber <peter.vielhaber@iohk.io>
Co-authored-by: patlo-iog <pat.losoponkul@iohk.io>
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa pushed a commit that referenced this pull request Mar 6, 2024
Signed-off-by: Pete Vielhaber <peter.vielhaber@iohk.io>
Co-authored-by: patlo-iog <pat.losoponkul@iohk.io>
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
Signed-off-by: Pete Vielhaber <peter.vielhaber@iohk.io>
Co-authored-by: patlo-iog <pat.losoponkul@iohk.io>
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
Signed-off-by: Pete Vielhaber <peter.vielhaber@iohk.io>
Co-authored-by: patlo-iog <pat.losoponkul@iohk.io>
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
Signed-off-by: Pete Vielhaber <peter.vielhaber@iohk.io>
Co-authored-by: patlo-iog <pat.losoponkul@iohk.io>
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants