Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OAS and http clients for Kotliln and TypeScript #1375

Merged
merged 21 commits into from
Sep 26, 2024

Conversation

yshyn-iohk
Copy link
Member

Description:

  • fixed OAS for enums
  • fixed Kotling and TS cliets

Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Copy link
Contributor

github-actions bot commented Sep 25, 2024

Unit Test Results

102 files  ±0  102 suites  ±0   20m 57s ⏱️ +50s
872 tests ±0  864 ✅ ±0  8 💤 ±0  0 ❌ ±0 
879 runs  ±0  871 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 20c9f2d. ± Comparison against base commit 5c984ee.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Sep 25, 2024

Coverage Status

coverage: 48.66% (+0.05%) from 48.609%
when pulling 20c9f2d on vdr-e2e-tests
into 5c984ee on ATL-6543-epic-vdr-phase-3.

Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Shota Jolbordi added 2 commits September 26, 2024 19:23
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
Copy link

@mattklepp mattklepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add other that add some error handling and comments. Look at ManageIssuerSteps.kt line 102 to 108. the !! the forced unwrapping can lead to exceptions. Could be more readable.

LIKE:
// Retrieve the last response and extract the list of issuers.
val response = SerenityRest.lastResponse().get()
val issuers = response.contents ?: error("No issuers found in the response")

// Find the updated issuer by ID.
val updatedIssuer = issuers.find { it.id == credentialIssuer.id }
?: error("Issuer with ID ${credentialIssuer.id} not found")

// Verify the authorization server URL.
issuer.attemptsTo(
Ensure.that(updatedIssuer.authorizationServerUrl).isEqualTo(UPDATE_AUTH_SERVER_URL)
)

Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Copy link
Contributor

github-actions bot commented Sep 26, 2024

Integration Test Results

20 files  20 suites   2s ⏱️
45 tests 45 ✅ 0 💤 0 ❌
71 runs  71 ✅ 0 💤 0 ❌

Results for commit 20c9f2d.

♻️ This comment has been updated with latest results.

@yshyn-iohk
Copy link
Member Author

@mattklepp, thanks for reviewing our code
the comments to the code is not required
as soon as you work with this codebase, all these actions are self-explained as we use a DSL provided by the test framework

Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
@shotexa shotexa merged commit d69e35e into ATL-6543-epic-vdr-phase-3 Sep 26, 2024
11 checks passed
@shotexa shotexa deleted the vdr-e2e-tests branch September 26, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants