-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: OAS and http clients for Kotliln and TypeScript #1375
Conversation
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
cloud-agent/client/kotlin/src/main/kotlin/org/hyperledger/identus/client/models/Service.kt
Outdated
Show resolved
Hide resolved
...core/src/main/scala/org/hyperledger/identus/pollux/core/model/ResourceResolutionMethod.scala
Show resolved
Hide resolved
pollux/sql-doobie/src/main/scala/org/hyperledger/identus/pollux/sql/repository/Implicits.scala
Show resolved
Hide resolved
...in/scala/org/hyperledger/identus/pollux/credentialschema/http/CredentialSchemaResponse.scala
Outdated
Show resolved
Hide resolved
...core/src/main/scala/org/hyperledger/identus/pollux/core/model/ResourceResolutionMethod.scala
Show resolved
Hide resolved
cloud-agent/client/kotlin/src/main/kotlin/org/hyperledger/identus/client/models/Service.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
edbd9b6
to
768b1fb
Compare
Signed-off-by: Hyperledger Bot <hyperledger-bot@hyperledger.org> Co-authored-by: Hyperledger Bot <hyperledger-bot@hyperledger.org>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to add other that add some error handling and comments. Look at ManageIssuerSteps.kt line 102 to 108. the !! the forced unwrapping can lead to exceptions. Could be more readable.
LIKE:
// Retrieve the last response and extract the list of issuers.
val response = SerenityRest.lastResponse().get()
val issuers = response.contents ?: error("No issuers found in the response")
// Find the updated issuer by ID.
val updatedIssuer = issuers.find { it.id == credentialIssuer.id }
?: error("Issuer with ID ${credentialIssuer.id} not found")
// Verify the authorization server URL.
issuer.attemptsTo(
Ensure.that(updatedIssuer.authorizationServerUrl).isEqualTo(UPDATE_AUTH_SERVER_URL)
)
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Integration Test Results20 files 20 suites 2s ⏱️ Results for commit 20c9f2d. ♻️ This comment has been updated with latest results. |
@mattklepp, thanks for reviewing our code |
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Description: