Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust Kotlin and TypeScript HTTP client to use the schemaId f… #1388

Merged
merged 11 commits into from
Oct 9, 2024

Conversation

yshyn-iohk
Copy link
Member

@yshyn-iohk yshyn-iohk commented Oct 7, 2024

…rom VCDM2.0 (string or list of strings)

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

…rom VCDM2.0 (string or list of strings)

Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
@yshyn-iohk yshyn-iohk requested a review from a team as a code owner October 7, 2024 11:46
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Unit Test Results

102 files  ±0  102 suites  ±0   19m 17s ⏱️ -35s
874 tests ±0  866 ✅ ±0  8 💤 ±0  0 ❌ ±0 
881 runs  ±0  873 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit c820782. ± Comparison against base commit 7b4a9c1.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Oct 7, 2024

Coverage Status

coverage: 48.653%. remained the same
when pulling c820782 on fix/update-test-depedencies
into 7b4a9c1 on main.

…o 2.13.13

Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
@yshyn-iohk yshyn-iohk force-pushed the fix/update-test-depedencies branch from 2583a83 to bbcedb1 Compare October 7, 2024 13:10
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Copy link

@mattklepp mattklepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good.

Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Integration Test Results

20 files  ±0  20 suites  ±0   2s ⏱️ ±0s
49 tests ±0  49 ✅ ±0  0 💤 ±0  0 ❌ ±0 
88 runs  ±0  88 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c820782. ± Comparison against base commit 7b4a9c1.

♻️ This comment has been updated with latest results.

Copy link

@mattklepp mattklepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent.

Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
@github-actions github-actions bot added the ci label Oct 9, 2024
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
@yshyn-iohk yshyn-iohk enabled auto-merge (squash) October 9, 2024 07:03
@yshyn-iohk yshyn-iohk merged commit c2da492 into main Oct 9, 2024
13 checks passed
@yshyn-iohk yshyn-iohk deleted the fix/update-test-depedencies branch October 9, 2024 07:05
bytewizard42i pushed a commit to bytewizard42i/identus-cloud-agent that referenced this pull request Nov 13, 2024
# [1.40.0](hyperledger/identus-cloud-agent@cloud-agent-v1.39.0...cloud-agent-v1.40.0) (2024-11-05)

### Bug Fixes

* Add key_id missing field ([hyperledger#1403](hyperledger#1403)) ([cbd1a03](hyperledger@cbd1a03))
* adjust Kotlin and TypeScript HTTP client to use the `schemaId` f… ([hyperledger#1388](hyperledger#1388)) ([c2da492](hyperledger@c2da492))
* cannot reuse the same credential-offer in oid4vci ([hyperledger#1361](hyperledger#1361)) ([6a0a3ea](hyperledger@6a0a3ea))
* handle unsupported PIURI found in DIDComm messages accordingly ([hyperledger#1399](hyperledger#1399)) ([9b64793](hyperledger@9b64793))
* key id for jwt and sdjwt ([hyperledger#1420](hyperledger#1420)) ([5830a7e](hyperledger@5830a7e))
* oas to use any schema for json ast node ([hyperledger#1372](hyperledger#1372)) ([95d328e](hyperledger@95d328e))
* oid4vci endpoints error statuses and negative input validation ([hyperledger#1384](hyperledger#1384)) ([65cc9a7](hyperledger@65cc9a7))
* Preserve Presentation Format ([hyperledger#1363](hyperledger#1363)) ([c18385c](hyperledger@c18385c))
* return 404 when create credConfig on non-existing issuer ([hyperledger#1379](hyperledger#1379)) ([e532ba6](hyperledger@e532ba6))

### Features

* Add KID to the credential-offers API - ATL-7704 ([hyperledger#1320](hyperledger#1320)) ([56200cf](hyperledger@56200cf))
* add presentation-exchange endpoints ([hyperledger#1365](hyperledger#1365)) ([49f7ab3](hyperledger@49f7ab3))
* ATL-6983 ZIO Stream Kafka PoC in background jobs ([hyperledger#1339](hyperledger#1339)) ([19ab426](hyperledger@19ab426))
* Default Backend API to Array Of Credential Schema ([hyperledger#1366](hyperledger#1366)) ([693dcc4](hyperledger@693dcc4))
* Default Object As Issuer ([hyperledger#1349](hyperledger#1349)) ([d29eebb](hyperledger@d29eebb))
* Implement prism anoncreds method for schemas and credential definitions ([hyperledger#1385](hyperledger#1385)) ([fbee055](hyperledger@fbee055))
* Issuer Replace Either By Union Type ([hyperledger#1374](hyperledger#1374)) ([8fc2fe3](hyperledger@8fc2fe3))
* presentation_submission validation logic ([hyperledger#1332](hyperledger#1332)) ([f80b3c3](hyperledger@f80b3c3))
* Support Array Of Credential Schema ([hyperledger#1351](hyperledger#1351)) ([948e314](hyperledger@948e314))
* Test JWT OBJECT as Issuer ([hyperledger#1343](hyperledger#1343)) ([7208d95](hyperledger@7208d95))
* VC support for Array of credential Status ([hyperledger#1383](hyperledger#1383)) ([ad946cf](hyperledger@ad946cf))
* VCVerification API support ARRAY or OBJECT as Credential Sc… ([hyperledger#1355](hyperledger#1355)) ([91cb4e7](hyperledger@91cb4e7))

 [skip ci]

Signed-off-by: Hyperledger Bot <hyperledger-bot@hyperledger.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants