feat: align the credential schema property name according to the VCDM 1.1 #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
…m1_1 # Conflicts: # tests/integration-tests/src/test/kotlin/common/CredentialSchema.kt # tests/integration-tests/src/test/kotlin/steps/connectionless/ConnectionLessSteps.kt # tests/integration-tests/src/test/kotlin/steps/credentials/JwtCredentialSteps.kt # tests/integration-tests/src/test/resources/features/credential/jwt/issuance.feature # tests/integration-tests/src/test/resources/features/credential/sdjwt/issuance.feature
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Integration Test Results20 files ±0 20 suites ±0 2s ⏱️ ±0s Results for commit 3449faa. ± Comparison against base commit 7365497. This pull request removes 2 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
…m1_1 # Conflicts: # tests/integration-tests/src/test/resources/features/credential/jwt/present_proof.feature
…s-cloud-agent-client-ts Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
bvoiturier
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
schemaIdand created the alternative that is aligned with the specification (JWT/SD-JWT/AnonCreds)schemaIdproperty to the create credential offer request for JWT/SD-JWT VCcredentialSchemaproperty that is aligned with VCDM 1.1 to the domain and HTTP layersIn the next iteration, the new HTTP client will be generated and additional e2e tests will be added.
Checklist: