feat: add feature flag to enable/disable support for Anoncred (backend job and API) #1491

[FabioPinheiro]

Add a configuration feature flag to enable or disable support for certain type of credentials like Anomcred

[github-actions]

Unit Test Results

104 files  ±0  104 suites  ±0   20m 17s ⏱️ + 3m 1s
882 tests ±0  874 ✅ ±0  8 💤 ±0  0 ❌ ±0 
889 runs  ±0  881 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit df14758. ± Comparison against base commit 37a8f41.

♻️ This comment has been updated with latest results.

[coveralls]

coverage: 48.691% (+0.05%) from 48.642%
when pulling df14758 on feat/feat_flag_for_anomcred
into 37a8f41 on main.

[yshyn-iohk]

Good job, @FabioPinheiro

What do you think about using the feature flags in the ZIO layer bootstrapping logic instead of in the business logic.
I afraid, that it might be harder to test the logic and additional feature flags might make the code hard to maintain.

[FabioPinheiro]

Good job, @FabioPinheiro

What do you think about using the feature flags in the ZIO layer bootstrapping logic instead of in the business logic. I afraid, that it might be harder to test the logic and additional feature flags might make the code hard to maintain.

I did exactly that discussion with @mineme0110 yesterday. We are slightly in favor of being in the ZIO environment. But to keep consistent, I decided to pass the flags as arguments (as it was already done in most places)

[FabioPinheiro]

So now the integration tests are failing as expected. How can we fix this?
The easier way is to add the configuration to behave us before. What about the new expected behavior but he default?

Present Proof Protocol #1.Holder presents anoncreds credential proof to verifier FAILED
    java.lang.AssertionError at LastResponseInteraction.kt:33

[mineme0110]

So now the integration tests are failing as expected. How can we fix this? The easier way is to add the configuration to behave us before. What about the new expected behavior but he default?

Present Proof Protocol #1.Holder presents anoncreds credential proof to verifier FAILED
    java.lang.AssertionError at LastResponseInteraction.kt:33

can we not run integration test with flag enabled

[yshyn-iohk]

I agree with @mineme0110.
Let's keep the e2e tests with all flags (it should be possible to set the corresponding env variables)
At the same time, we need to add negative use cases that prove disabling logic works well.

[FabioPinheiro]

So that is the "easier way". Although I have no idea how to configure the integration test

[github-actions]

Integration Test Results

20 files  ±0  20 suites  ±0   2s ⏱️ -1s
55 tests ±0  55 ✅ ±0  0 💤 ±0  0 ❌ ±0 
97 runs  ±0  97 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit df14758. ± Comparison against base commit 37a8f41.

[FabioPinheiro]

TODO I'm forgot to call the margin method...