refactor: update zio-http to 3.0.0-RC2 and tapir to 1.6.4, remove legacy tapir #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shotexa
requested review from
bvoiturier,
yshyn-iohk,
patlo-iog,
CryptoKnightIOG,
mineme0110 and
FabioPinheiro
as code owners
shotexa
changed the title
antonbaliasnikov
changed the title
antonbaliasnikov
approved these changes
Oct 2, 2023
yshyn-iohk
reviewed
Oct 2, 2023
mercury/mercury-library/agent-cli-didcommx/src/main/scala/io/iohk/atala/mercury/AgentCli.scala
Outdated
Show resolved
Hide resolved
patlo-iog
approved these changes
Oct 2, 2023
Comment on lines
+22
to
+25
| } | ||
| ZIO.fail(UnexpectedError(s"HTTP response error: $err")) | ||
| case _ => | ||
| ZIO.fail(UnexpectedError("Unknown error")) |
There was a problem hiding this comment.
A little confused by these 2 branches. When would the response.status not be error and we need return unexpected error.
There was a problem hiding this comment.
Technically, logically speaking never, because !response.status.isError can either be true or false, but just to make a match statement exhaustive
shotexa
force-pushed
the
ATL-5193-update-zio-http1
branch
from
bac693a to
8e51acc
Compare
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
Signed-off-by: Milos Backonja <milos.backonja@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
Signed-off-by: Milos Backonja <milos.backonja@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
## [1.16.1](prism-agent-v1.16.0...prism-agent-v1.16.1) (2023-09-27) ### Bug Fixes * Adding localhost environment variable in run.sh script for local development ([#728](#728)) ([1a904a6](1a904a6)) * correct typo on sts header (dmax -> max) ([#726](#726)) ([2c5bc51](2c5bc51)) * **prism-agent:** introduce generic secret store for CD ([#727](#727)) ([3d4aacd](3d4aacd)) * Separate config for integration flow ATL-5777 ([#731](#731)) ([9e0e2de](9e0e2de)) * Separate config for integration flow ATL-5777 ([#733](#733)) ([8380ccc](8380ccc)) Signed-off-by: Anton Baliasnikov <anton.baliasnikov@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
Signed-off-by: Milos Backonja <milos.backonja@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
Signed-off-by: Milos Backonja <milos.backonja@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
Signed-off-by: Milos Backonja <milos.backonja@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
## [1.16.2](prism-agent-v1.16.1...prism-agent-v1.16.2) (2023-09-28) ### Bug Fixes * Changing yq command [skip ci] ATL-5777 ([#736](#736)) ([01bdfa7](01bdfa7)) * Integration flow ([#734](#734)) ([c45a9eb](c45a9eb)) * Renaming values.yml [skip ci] ATL-5777 ([#735](#735)) ([bcd73c3](bcd73c3)) Signed-off-by: Anton Baliasnikov <anton.baliasnikov@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
Signed-off-by: Milos Backonja <milos.backonja@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
## [1.16.3](prism-agent-v1.16.2...prism-agent-v1.16.3) (2023-09-28) ### Bug Fixes * Adding labels [skip ci] ([#737](#737)) ([5182098](5182098)) Signed-off-by: Anton Baliasnikov <anton.baliasnikov@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
Signed-off-by: Milos Backonja <milos.backonja@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
## [1.16.4](prism-agent-v1.16.3...prism-agent-v1.16.4) (2023-09-29) ### Bug Fixes * Integration flow ATL-5777 ([#738](#738)) ([7cf927c](7cf927c)) Signed-off-by: Anton Baliasnikov <anton.baliasnikov@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
Signed-off-by: Pat Losoponkul <pat.losoponkul@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
…p ci] (#730) Signed-off-by: Pat Losoponkul <pat.losoponkul@iohk.io> Co-authored-by: Yurii Shynbuiev - IOHK <yurii.shynbuiev@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
…r + return 'metaRetries' (#740) Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io> Signed-off-by: Milos Backonja <milos.backonja@iohk.io> Signed-off-by: Anton Baliasnikov <anton.baliasnikov@iohk.io> Signed-off-by: Pat Losoponkul <pat.losoponkul@iohk.io> Co-authored-by: Milos Backonja <35807060+milosbackonja@users.noreply.github.com> Co-authored-by: atala-dev <atala.dev@iohk.io> Co-authored-by: patlo-iog <pat.losoponkul@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
…ohk/atala/mercury/AgentCli.scala Co-authored-by: Yurii Shynbuiev - IOHK <yurii.shynbuiev@iohk.io> Signed-off-by: shotexa <shota.jolbordi@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa
force-pushed
the
ATL-5193-update-zio-http1
branch
from
807bc53 to
41976f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes ATL-5193
Checklist
My PR contains...
My changes...
Documentation
Tests