Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add credential definition docs #748

Merged

Conversation

CryptoKnightIOG
Copy link
Contributor

@CryptoKnightIOG CryptoKnightIOG commented Oct 8, 2023

Overview

Fixes https://input-output.atlassian.net/browse/ATL-5851

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

Atala PRISM Test Results

  79 files  +2    79 suites  +2   15m 8s ⏱️ + 1m 9s
673 tests +1  662 ✔️ +1  11 💤 ±0  0 ±0 
679 runs  +1  668 ✔️ +1  11 💤 ±0  0 ±0 

Results for commit a1db334. ± Comparison against base commit a579aa9.

This pull request removes 29 and adds 30 tests. Note that renamed tests count towards both.
io.iohk.atala.issue.controller.IssueControllerImplSpec ‑ IssueControllerImp http failure cases - provide incorrect subjectId to endpoint
io.iohk.atala.pollux.core.repository.CredentialRepositoryInMemorySpec ‑ Credential Repository In Memory test suite - CRUD operations - updateCredentialRecordPublicationState doesn't update the record for invalid from state
io.iohk.atala.pollux.core.repository.CredentialRepositoryInMemorySpec ‑ Credential Repository In Memory test suite - CRUD operations - updateCredentialRecordPublicationState updates the record
io.iohk.atala.pollux.core.service.CredentialServiceImplSpec ‑ CredentialServiceImpl - singleWalletSpec - Happy flow is successfully executed
io.iohk.atala.pollux.core.service.CredentialServiceImplSpec ‑ CredentialServiceImpl - singleWalletSpec - acceptCredentialOffer cannot be called twice for the same record
io.iohk.atala.pollux.core.service.CredentialServiceImplSpec ‑ CredentialServiceImpl - singleWalletSpec - acceptCredentialOffer should reject unsupported `subjectId` format
io.iohk.atala.pollux.core.service.CredentialServiceImplSpec ‑ CredentialServiceImpl - singleWalletSpec - acceptCredentialOffer updates the record's protocol state
io.iohk.atala.pollux.core.service.CredentialServiceImplSpec ‑ CredentialServiceImpl - singleWalletSpec - acceptCredentialRequest cannot be called twice for the same record
io.iohk.atala.pollux.core.service.CredentialServiceImplSpec ‑ CredentialServiceImpl - singleWalletSpec - acceptCredentialRequest successfully updates the record
io.iohk.atala.pollux.core.service.CredentialServiceImplSpec ‑ CredentialServiceImpl - singleWalletSpec - createIssuerCredentialRecord should reject creation with a duplicate 'thid'
…
io.iohk.atala.issue.controller.IssueControllerImplSpec ‑ IssueControllerImp http failure cases - provide incorrect recordId to endpoint
io.iohk.atala.pollux.anoncreds.PoCNewLib ‑ LinkSecret should be able to parse back to the anoncreds lib
io.iohk.atala.pollux.anoncreds.PoCNewLib ‑ The POC New Lib script should run to completion
io.iohk.atala.pollux.core.service.CredentialServiceImplSpec ‑ CredentialServiceImpl - Single Wallet JWT Credential - Happy flow is successfully executed
io.iohk.atala.pollux.core.service.CredentialServiceImplSpec ‑ CredentialServiceImpl - Single Wallet JWT Credential - acceptCredentialOffer cannot be called twice for the same record
io.iohk.atala.pollux.core.service.CredentialServiceImplSpec ‑ CredentialServiceImpl - Single Wallet JWT Credential - acceptCredentialOffer should reject unsupported `subjectId` format
io.iohk.atala.pollux.core.service.CredentialServiceImplSpec ‑ CredentialServiceImpl - Single Wallet JWT Credential - acceptCredentialOffer updates the record's protocol state
io.iohk.atala.pollux.core.service.CredentialServiceImplSpec ‑ CredentialServiceImpl - Single Wallet JWT Credential - acceptCredentialRequest cannot be called twice for the same record
io.iohk.atala.pollux.core.service.CredentialServiceImplSpec ‑ CredentialServiceImpl - Single Wallet JWT Credential - acceptCredentialRequest successfully updates the record
io.iohk.atala.pollux.core.service.CredentialServiceImplSpec ‑ CredentialServiceImpl - Single Wallet JWT Credential - createIssuerCredentialRecord should reject creation with a duplicate 'thid'
…

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

Integration Test Results

11 files  ±0  11 suites  ±0   3s ⏱️ ±0s
25 tests ±0  25 ✔️ ±0  0 💤 ±0  0 ±0 
37 runs  ±0  37 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit a1db334. ± Comparison against base commit a579aa9.

Copy link
Contributor

@bvoiturier bvoiturier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@bvoiturier bvoiturier merged commit 6a744e8 into feat/new-anoncred-endpoints Oct 9, 2023
@bvoiturier bvoiturier deleted the docs/add-credential-definition-docs branch October 9, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants