Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix typo in docs link #764

Merged
merged 3 commits into from
Oct 20, 2023
Merged

docs: fix typo in docs link #764

merged 3 commits into from
Oct 20, 2023

Conversation

elribonazo
Copy link
Contributor

@elribonazo elribonazo commented Oct 20, 2023 •
edited
Loading

Overview

Fixes ATL-5875

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@elribonazo
fix: replace broken link
5cacc83 
Signed-off-by: Francisco Javier Ribó <elribonazo@gmail.com>
@elribonazo
docs: fix typo in credential issue docs
86f0fe9 
Signed-off-by: Francisco Javier Ribó <elribonazo@gmail.com>
@elribonazo
Merge branch 'main' into feature/ATL-5875
b2631e9 
* main:
  docs: replace broken link in Issue.md, AnonCreds Credential definition (#763)

Signed-off-by: Francisco Javier Ribó <elribonazo@gmail.com>

# Conflicts:
#	docs/docusaurus/credentials/issue.md
@elribonazo elribonazo requested a review from a user October 20, 2023 11:40
@github-actions
Copy link
Contributor

Atala PRISM Test Results

  79 files  ±0    79 suites  ±0   13m 45s ⏱️ - 1m 25s
680 tests ±0  669 ✔️ ±0  11 💤 ±0  0 ❌ ±0 
686 runs  ±0  675 ✔️ ±0  11 💤 ±0  0 ❌ ±0 

Results for commit b2631e9. ± Comparison against base commit ce7acd4.

@github-actions
Copy link
Contributor

Integration Test Results

11 files  ±0  11 suites  ±0   3s ⏱️ ±0s
25 tests ±0  25 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
37 runs  ±0  37 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit b2631e9. ± Comparison against base commit ce7acd4.

@elribonazo elribonazo merged commit 51cd5cd into main Oct 20, 2023
11 checks passed
@elribonazo elribonazo deleted the feature/ATL-5875 branch October 20, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goncalo-frade-iohk goncalo-frade-iohk goncalo-frade-iohk approved these changes

@hamada147 hamada147 hamada147 approved these changes

@curtis-h curtis-h Awaiting requested review from curtis-h

@antonbaliasnikov antonbaliasnikov Awaiting requested review from antonbaliasnikov

@yshyn-iohk yshyn-iohk Awaiting requested review from yshyn-iohk

@BS-IO BS-IO Awaiting requested review from BS-IO

Assignees
No one assigned
Labels
Type: Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elribonazo @hamada147 @goncalo-frade-iohk @atala-dev