Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add anoncreds issuance happy path bdd scenario #767

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

antonbaliasnikov
Copy link

Overview

Adds an integration test for anoncreds issuance

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

Signed-off-by: Anton Baliasnikov <anton.baliasnikov@iohk.io>
@antonbaliasnikov antonbaliasnikov changed the title tests: add anoncreds issuance happy path integration test test: add anoncreds issuance happy path bdd scenario Oct 25, 2023
@github-actions
Copy link
Contributor

Atala PRISM Test Results

  79 files  ±0    79 suites  ±0   15m 39s ⏱️ -2s
680 tests ±0  669 ✔️ ±0  11 💤 ±0  0 ±0 
686 runs  ±0  675 ✔️ ±0  11 💤 ±0  0 ±0 

Results for commit a8e01c1. ± Comparison against base commit 43083a3.

@github-actions
Copy link
Contributor

Integration Test Results

11 files  ±0  11 suites  ±0   4s ⏱️ -1s
24 tests +1  24 ✔️ +1  0 💤 ±0  0 ±0 
25 runs  +1  25 ✔️ +1  0 💤 ±0  0 ±0 

Results for commit a8e01c1. ± Comparison against base commit 43083a3.

This pull request removes 2 and adds 3 tests. Note that renamed tests count towards both.
Issuing credential with published PRISM DID to unpublished PRISM DID
Issuing credential with unpublished PRISM DID to unpublished PRISM DID
Issuing anoncred with published PRISM DID
Issuing credential with published PRISM DID
Issuing credential with unpublished PRISM DID

Copy link
Contributor

@bvoiturier bvoiturier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @antonbaliasnikov, thanks! ❤️

@antonbaliasnikov antonbaliasnikov merged commit 5558a9e into main Oct 25, 2023
10 of 11 checks passed
@antonbaliasnikov antonbaliasnikov deleted the anoncreds-issuance-integration-test branch October 25, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants