Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create/Store presentation proof request #774

Merged
merged 1 commit into from
Oct 31, 2023
Merged

feat: Create/Store presentation proof request #774

merged 1 commit into from
Oct 31, 2023

Conversation

CryptoKnightIOG
Copy link
Contributor

@CryptoKnightIOG CryptoKnightIOG commented Oct 31, 2023 •
edited
Loading

Overview

Fixes https://input-output.atlassian.net/browse/ATL-5966

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@CryptoKnightIOG CryptoKnightIOG changed the base branch from main to ATL-5966-Create-Presentation-Proof-Request-2 October 31, 2023 00:29
@CryptoKnightIOG CryptoKnightIOG changed the base branch from ATL-5966-Create-Presentation-Proof-Request-2 to feat/ZKP-verification October 31, 2023 00:32
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2023 •
edited
Loading

Atala PRISM Test Results

  79 files    79 suites   14m 29s ⏱️
680 tests 669 ✔️ 11 💤 0 ❌
686 runs  675 ✔️ 11 💤 0 ❌

Results for commit 14a3b86.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2023 •
edited
Loading

Integration Test Results

11 files  11 suites   3s ⏱️
24 tests 24 ✔️ 0 💤 0 ❌
25 runs  25 ✔️ 0 💤 0 ❌

Results for commit 14a3b86.

♻️ This comment has been updated with latest results.

@CryptoKnightIOG
feat: ATL-5966 Create/Store Presentation Request
14a3b86 
Signed-off-by: Bassam Riman <bassam.riman@iohk.io>
@CryptoKnightIOG CryptoKnightIOG force-pushed the ATL-5966-Create-Presentation-Proof-Request-3 branch from 4f2bdfa to 14a3b86 Compare October 31, 2023 00:54
bvoiturier
bvoiturier approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@bvoiturier bvoiturier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @CryptoKnightIOG! Great progress 👍

@CryptoKnightIOG CryptoKnightIOG merged commit 50045f6 into feat/ZKP-verification Oct 31, 2023
10 checks passed
@CryptoKnightIOG CryptoKnightIOG deleted the ATL-5966-Create-Presentation-Proof-Request-3 branch October 31, 2023 12:30
CryptoKnightIOG added a commit that referenced this pull request Nov 15, 2023
@CryptoKnightIOG
feat: Create/Store presentation proof request (#774)
5fa0b58 
Signed-off-by: Bassam Riman <bassam.riman@iohk.io>
CryptoKnightIOG added a commit that referenced this pull request Nov 18, 2023
@CryptoKnightIOG
feat: Create/Store presentation proof request (#774)
4622c02 
Signed-off-by: Bassam Riman <bassam.riman@iohk.io>
CryptoKnightIOG added a commit that referenced this pull request Nov 20, 2023
@CryptoKnightIOG
feat: Create/Store presentation proof request (#774)
417f9bc 
Signed-off-by: Bassam Riman <bassam.riman@iohk.io>
CryptoKnightIOG added a commit that referenced this pull request Nov 22, 2023
@CryptoKnightIOG
feat: Create/Store presentation proof request (#774)
95bcd1e 
Signed-off-by: Bassam Riman <bassam.riman@iohk.io>
CryptoKnightIOG added a commit that referenced this pull request Nov 30, 2023
@CryptoKnightIOG
feat: Create/Store presentation proof request (#774)
d6f1fd6 
Signed-off-by: Bassam Riman <bassam.riman@iohk.io>
CryptoKnightIOG added a commit that referenced this pull request Dec 19, 2023
@CryptoKnightIOG
feat: Create/Store presentation proof request (#774)
4968c40 
Signed-off-by: Bassam Riman <bassam.riman@iohk.io>
CryptoKnightIOG added a commit that referenced this pull request Dec 20, 2023
@CryptoKnightIOG
feat: Create/Store presentation proof request (#774)
f25ec80 
Signed-off-by: Bassam Riman <bassam.riman@iohk.io>
CryptoKnightIOG added a commit that referenced this pull request Jan 3, 2024
@CryptoKnightIOG
feat: Create/Store presentation proof request (#774)
586fabf 
Signed-off-by: Bassam Riman <bassam.riman@iohk.io>
CryptoKnightIOG added a commit that referenced this pull request Jan 24, 2024
@CryptoKnightIOG
feat: Create/Store presentation proof request (#774)
32ccb6e 
Signed-off-by: Bassam Riman <bassam.riman@iohk.io>
CryptoKnightIOG added a commit that referenced this pull request Feb 3, 2024
@CryptoKnightIOG
feat: Create/Store presentation proof request (#774)
9c3bf12 
Signed-off-by: Bassam Riman <bassam.riman@iohk.io>
CryptoKnightIOG added a commit that referenced this pull request Feb 9, 2024
@CryptoKnightIOG
feat: Create/Store presentation proof request (#774)
c536c10 
Signed-off-by: Bassam Riman <bassam.riman@iohk.io>
CryptoKnightIOG added a commit that referenced this pull request Feb 9, 2024
@CryptoKnightIOG
feat: Create/Store presentation proof request (#774)
b576c54 
Signed-off-by: Bassam Riman <bassam.riman@iohk.io>
CryptoKnightIOG added a commit that referenced this pull request Feb 18, 2024
@CryptoKnightIOG
feat: Create/Store presentation proof request (#774)
c83adee 
Signed-off-by: Bassam Riman <bassam.riman@iohk.io>
CryptoKnightIOG added a commit that referenced this pull request Feb 23, 2024
@CryptoKnightIOG
feat: Create/Store presentation proof request (#774)
4edcb0a 
Signed-off-by: Bassam Riman <bassam.riman@iohk.io>
CryptoKnightIOG added a commit that referenced this pull request Feb 28, 2024
@CryptoKnightIOG
feat: Create/Store presentation proof request (#774)
94401d1 
Signed-off-by: Bassam Riman <bassam.riman@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yshyn-iohk yshyn-iohk yshyn-iohk approved these changes

@bvoiturier bvoiturier bvoiturier approved these changes

@patlo-iog patlo-iog Awaiting requested review from patlo-iog

@mineme0110 mineme0110 Awaiting requested review from mineme0110

Assignees
No one assigned
Labels
Component: Cloud Agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CryptoKnightIOG @bvoiturier @yshyn-iohk @atala-dev