feat: Create & Store Presentation #794

CryptoKnightIOG · 2023-11-20T13:39:58Z

Overview

Fixes https://input-output.atlassian.net/browse/ATL-6019

Checklist

My PR contains...

No code changes (changes to documentation, CI, metadata, etc.)
Bug fixes (non-breaking change which fixes an issue)
Improvements (misc. changes to existing features)
Features (non-breaking change which adds functionality)

My changes...

are breaking changes
are not breaking changes
If yes to above: I have updated the documentation accordingly

Documentation

My changes do not require a change to the project documentation
My changes require a change to the project documentation
If yes to above: I have updated the documentation accordingly

Tests

My changes can not or do not need to be tested
My changes can and should be tested by unit and/or integration tests
If yes to above: I have added tests to cover my changes
If yes to above: I have taken care to cover edge cases in my tests

github-actions · 2023-11-20T13:49:30Z

Integration Test Results

11 files ±0 11 suites ±0 2s ⏱️ ±0s
24 tests ±0 24 ✔️ ±0 0 💤 ±0 0 ❌ ±0
25 runs ±0 25 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit ebae28a. ± Comparison against base commit 5376b74.

♻️ This comment has been updated with latest results.

github-actions · 2023-11-20T13:53:26Z

Atala PRISM Test Results

  87 files ±0   87 suites ±0 21m 19s ⏱️ -9s
723 tests +1 715 ✔️ +1 8 💤 ±0 0 ❌ ±0
729 runs +1 721 ✔️ +1 8 💤 ±0 0 ❌ ±0

Results for commit 911e2e6. ± Comparison against base commit 7e18b6a.

github-actions · 2023-11-20T14:53:25Z

Unit Test Results

  87 files ±0   87 suites ±0 21m 29s ⏱️ -6s
723 tests +1 715 ✔️ +1 8 💤 ±0 0 ❌ ±0
729 runs +1 721 ✔️ +1 8 💤 ±0 0 ❌ ±0

Results for commit ebae28a. ± Comparison against base commit 5376b74.

♻️ This comment has been updated with latest results.

yshyn-iohk · 2023-11-20T15:29:31Z

pollux/lib/anoncreds/src/main/scala/io/iohk/atala/pollux/anoncreds/AnoncredLib.scala

  def createPresentation(
      presentationRequest: PresentationRequest,
-      credentials: Seq[Credential],
+      credentialRequests: Seq[CredentialAndRequestedAttributesPredicates],


would it be a good naming:
presentationRequest: AnonCredsPresentationRequest?

yshyn-iohk · 2023-11-21T05:10:58Z

pollux/lib/anoncreds/src/main/scala/io/iohk/atala/pollux/anoncreds/AnoncredLib.scala

@@ -159,8 +163,17 @@ object AnoncredLib {
      )
  }

+  // TODO FIX


@CryptoKnightIOG, can you create a test for this issue and a ticket in the jira or add any other documentation that describes this issue?

This was added by Fabio. Will follow up with him.

yshyn-iohk · 2023-11-21T05:13:11Z

pollux/lib/anoncreds/src/main/scala/io/iohk/atala/pollux/anoncreds/Models.scala

+)
+
+object CredentialAndRequestedAttributesPredicates {
+  given Conversion[CredentialAndRequestedAttributesPredicates, UniffiCredentialRequests] with {


in my personal opinion a good name for CredentialAndRequestedAttributesPredicates is CredentialRequests or AnonCredsV1.CredentialRequests (if we can isolate the types the corresponds to the V1)

yshyn-iohk · 2023-11-21T05:16:20Z

pollux/lib/core/src/main/scala/io/iohk/atala/pollux/core/service/PresentationServiceImpl.scala

+    for {
+      maybeRecord <- presentationRepository
+        .getPresentationRecord(recordId)
+        .mapError(RepositoryError.apply)


I think, it's a good practice to call logError as well before mapError, so we can track what exactly is wrong

The best way to handle this should defined in the ADR part of the Error Management value brief. I'll add this specific case - call to mapError() - to the list 👍

yshyn-iohk · 2023-11-21T05:18:39Z

pollux/lib/core/src/main/scala/io/iohk/atala/pollux/core/service/PresentationServiceImpl.scala

+      schemaMap <-
+        ZIO
+          .collectAll(schemaIds.map { schemaId =>
+            for {
+              uri <- ZIO.attempt(new URI(schemaId)).mapError(e => UnexpectedError(e.getMessage))
+              content <- uriDereferencer.dereference(uri).mapError(e => UnexpectedError(e.error))
+              vcSchema <- parseCredentialSchema(content).mapError(e => UnexpectedError(e.message))
+              anoncredSchema <- AnoncredSchemaSerDesV1.schemaSerDes
+                .deserialize(vcSchema.schema)
+                .mapError(e => UnexpectedError(e.error))
+              anoncredLibSchema =
+                SchemaDef(
+                  schemaId,
+                  anoncredSchema.version,
+                  anoncredSchema.attrNames,
+                  anoncredSchema.issuerId
+                )
+            } yield (schemaId, anoncredLibSchema)
+          })
+          .map(_.toMap)


I would recommend extracting this logic into the method. Something like resolveSchema(schemaId)

yshyn-iohk · 2023-11-21T05:19:29Z

pollux/lib/core/src/main/scala/io/iohk/atala/pollux/core/service/PresentationServiceImpl.scala

+            ).toEither
+          )
+          .mapError((t: Throwable) => AnoncredPresentationCreationError(t))
+    } yield presentation
  }


the method is tooooo long :)
try to refactor it to a sequence of smaller functions next time.

yshyn-iohk · 2023-11-21T05:21:28Z

...ib/core/src/test/scala/io/iohk/atala/pollux/core/service/PresentationServiceSpecHelper.scala

+    ): ZIO[WalletAccessContext, PresentationError, PresentationRecord] = {
+      val anoncredPresentationRequestV1 = AnoncredPresentationRequestV1(
+        requested_attributes = Map(
+          "sex" -> AnoncredRequestedAttributeV1(


Probably, a good idea for refactoring is to create a package or object AnoncredsV1 and all corresponding domain classes. RequestedAttribute etc.

Yep good idea

yshyn-iohk

Good job, @CryptoKnightIOG! Keep codding 👍

bvoiturier · 2023-11-21T08:37:20Z

...nt/service/server/src/main/scala/io/iohk/atala/agent/server/jobs/PresentBackgroundJobs.scala

-                            mediaType = Some("prism/jwt")
+                  presentation <-
+                    credentialFormat match {
+                      case CredentialFormat.JWT =>


Similar to what we did for the IssueBackgroundJobs class, I propose to move the logic for each case to the PresentationService implementation. It initially leaked to the background job class because Pollux had no access to the ManagedDIDService, which is now solved.

Note that it implies a bit of refactoring (also at the unit tests level!), so we could handle this as a tech-debt item if we don't want to hamper the delivery of this verification Epic 👍

Yes, I will do a refactor. In the end, because there are patterns forming.

bvoiturier · 2023-11-21T09:11:17Z

pollux/lib/anoncreds/src/main/scala/io/iohk/atala/pollux/anoncreds/AnoncredLib.scala

+  // TODO FIX
+  // [info] uniffi.anoncreds.AnoncredsException$CreatePresentationException: Create Presentation: Error: Error: Invalid structure
+  // [info] Caused by: Predicate is not satisfied
+


Do you need any help with those errors (e.g. from Fabio)?

@bvoiturier these were added by Fabio. Could be great if someone can have a look at them.

bvoiturier · 2023-11-21T09:31:28Z

pollux/lib/core/src/main/scala/io/iohk/atala/pollux/core/service/PresentationServiceImpl.scala

+    for {
+      maybeRecord <- presentationRepository
+        .getPresentationRecord(recordId)
+        .mapError(RepositoryError.apply)


The best way to handle this should defined in the ADR part of the Error Management value brief. I'll add this specific case - call to mapError() - to the list 👍

Signed-off-by: Bassam Riman <bassam.riman@iohk.io>

sonarqubecloud · 2023-11-22T16:20:50Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
7 Code Smells

No Coverage information
0.0% Duplication

Signed-off-by: Bassam Riman <bassam.riman@iohk.io>

atala-dev added pollux Component: Cloud Agent labels Nov 20, 2023

CryptoKnightIOG marked this pull request as ready for review November 20, 2023 13:40

CryptoKnightIOG requested review from bvoiturier, yshyn-iohk, patlo-iog and mineme0110 as code owners November 20, 2023 13:40

CryptoKnightIOG force-pushed the feat/ZKP-verification branch from 7e18b6a to 36c83d1 Compare November 20, 2023 14:07

CryptoKnightIOG changed the title ~~Atl 6019 create store presentation 2~~ feat: Create & Store Presentation Nov 20, 2023

CryptoKnightIOG force-pushed the ATL-6019-Create-Store-Presentation-2 branch 2 times, most recently from 474c547 to c4154df Compare November 20, 2023 14:39

yshyn-iohk reviewed Nov 20, 2023

View reviewed changes

yshyn-iohk reviewed Nov 21, 2023

View reviewed changes

yshyn-iohk approved these changes Nov 21, 2023

View reviewed changes

bvoiturier approved these changes Nov 21, 2023

View reviewed changes

CryptoKnightIOG force-pushed the feat/ZKP-verification branch from 36c83d1 to 5376b74 Compare November 22, 2023 00:06

ATL-6019: Create/Store Presentation

644d20f

Signed-off-by: Bassam Riman <bassam.riman@iohk.io>

CryptoKnightIOG force-pushed the ATL-6019-Create-Store-Presentation-2 branch from 0ea2a88 to 62d3dee Compare November 22, 2023 13:11

ATL-6019: Answer PR Comments

ebae28a

Signed-off-by: Bassam Riman <bassam.riman@iohk.io>

CryptoKnightIOG force-pushed the ATL-6019-Create-Store-Presentation-2 branch from 62d3dee to ebae28a Compare November 22, 2023 16:20

CryptoKnightIOG merged commit 1bf9287 into feat/ZKP-verification Nov 22, 2023
12 checks passed

CryptoKnightIOG deleted the ATL-6019-Create-Store-Presentation-2 branch November 22, 2023 16:41

CryptoKnightIOG added a commit that referenced this pull request Nov 30, 2023

feat: Create & Store Presentation (#794)

bef9239

Signed-off-by: Bassam Riman <bassam.riman@iohk.io>

CryptoKnightIOG added a commit that referenced this pull request Dec 19, 2023

feat: Create & Store Presentation (#794)

a06b861

Signed-off-by: Bassam Riman <bassam.riman@iohk.io>

CryptoKnightIOG added a commit that referenced this pull request Dec 20, 2023

feat: Create & Store Presentation (#794)

d641d83

Signed-off-by: Bassam Riman <bassam.riman@iohk.io>

CryptoKnightIOG added a commit that referenced this pull request Jan 3, 2024

feat: Create & Store Presentation (#794)

e24d62a

Signed-off-by: Bassam Riman <bassam.riman@iohk.io>

CryptoKnightIOG added a commit that referenced this pull request Jan 24, 2024

feat: Create & Store Presentation (#794)

13e48ba

Signed-off-by: Bassam Riman <bassam.riman@iohk.io>

CryptoKnightIOG added a commit that referenced this pull request Feb 3, 2024

feat: Create & Store Presentation (#794)

77c3174

Signed-off-by: Bassam Riman <bassam.riman@iohk.io>

CryptoKnightIOG added a commit that referenced this pull request Feb 9, 2024

feat: Create & Store Presentation (#794)

069b050

Signed-off-by: Bassam Riman <bassam.riman@iohk.io>

CryptoKnightIOG added a commit that referenced this pull request Feb 9, 2024

feat: Create & Store Presentation (#794)

1aa4e14

Signed-off-by: Bassam Riman <bassam.riman@iohk.io>

CryptoKnightIOG added a commit that referenced this pull request Feb 18, 2024

feat: Create & Store Presentation (#794)

c39434b

Signed-off-by: Bassam Riman <bassam.riman@iohk.io>

CryptoKnightIOG added a commit that referenced this pull request Feb 23, 2024

feat: Create & Store Presentation (#794)

2bc8035

Signed-off-by: Bassam Riman <bassam.riman@iohk.io>

CryptoKnightIOG added a commit that referenced this pull request Feb 28, 2024

feat: Create & Store Presentation (#794)

0e15763

Signed-off-by: Bassam Riman <bassam.riman@iohk.io>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Create & Store Presentation #794

feat: Create & Store Presentation #794

CryptoKnightIOG commented Nov 20, 2023 •

edited

Loading

github-actions bot commented Nov 20, 2023 •

edited

Loading

github-actions bot commented Nov 20, 2023

github-actions bot commented Nov 20, 2023 •

edited

Loading

yshyn-iohk Nov 20, 2023

yshyn-iohk Nov 21, 2023

CryptoKnightIOG Nov 21, 2023

yshyn-iohk Nov 21, 2023

yshyn-iohk Nov 21, 2023

bvoiturier Nov 21, 2023

CryptoKnightIOG Nov 21, 2023

yshyn-iohk Nov 21, 2023

CryptoKnightIOG Nov 21, 2023

yshyn-iohk Nov 21, 2023

CryptoKnightIOG Nov 21, 2023

yshyn-iohk Nov 21, 2023

CryptoKnightIOG Nov 21, 2023 •

edited

Loading

yshyn-iohk left a comment

bvoiturier Nov 21, 2023

CryptoKnightIOG Nov 21, 2023

bvoiturier Nov 21, 2023

CryptoKnightIOG Nov 21, 2023

bvoiturier Nov 21, 2023

sonarqubecloud bot commented Nov 22, 2023

feat: Create & Store Presentation #794

feat: Create & Store Presentation #794

Conversation

CryptoKnightIOG commented Nov 20, 2023 • edited Loading

Overview

Checklist

My PR contains...

My changes...

Documentation

Tests

github-actions bot commented Nov 20, 2023 • edited Loading

Integration Test Results

github-actions bot commented Nov 20, 2023

Atala PRISM Test Results

github-actions bot commented Nov 20, 2023 • edited Loading

Unit Test Results

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CryptoKnightIOG Nov 21, 2023 • edited Loading

Choose a reason for hiding this comment

yshyn-iohk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Nov 22, 2023

CryptoKnightIOG commented Nov 20, 2023 •

edited

Loading

github-actions bot commented Nov 20, 2023 •

edited

Loading

github-actions bot commented Nov 20, 2023 •

edited

Loading

CryptoKnightIOG Nov 21, 2023 •

edited

Loading