Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Anoncred Issuance Processing #831

Conversation

CryptoKnightIOG
Copy link
Contributor

Overview

Fixes https://input-output.atlassian.net/browse/ATL-6305

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@CryptoKnightIOG CryptoKnightIOG marked this pull request as ready for review December 22, 2023 20:38
Copy link
Contributor

github-actions bot commented Dec 22, 2023

Integration Test Results

11 files  ±0  11 suites  ±0   2s ⏱️ ±0s
24 tests ±0  24 ✅ ±0  0 💤 ±0  0 ❌ ±0 
25 runs  ±0  25 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 44a1663. ± Comparison against base commit adfc9bb.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 22, 2023

Unit Test Results

 87 files  ±0   87 suites  ±0   21m 36s ⏱️ -36s
725 tests ±0  717 ✅ ±0  8 💤 ±0  0 ❌ ±0 
735 runs  ±0  727 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 44a1663. ± Comparison against base commit adfc9bb.

♻️ This comment has been updated with latest results.

@CryptoKnightIOG CryptoKnightIOG force-pushed the ATL-6305-Fix-Credential-Processing branch from 42209b2 to b4d91c3 Compare January 3, 2024 18:53
Signed-off-by: Bassam Riman <bassam.riman@iohk.io>
@CryptoKnightIOG CryptoKnightIOG force-pushed the ATL-6305-Fix-Credential-Processing branch from b4d91c3 to 44a1663 Compare January 3, 2024 18:54
Copy link

sonarqubecloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@CryptoKnightIOG CryptoKnightIOG merged commit bded00c into ATL-6021-Receive-Store-Presentation Jan 3, 2024
10 of 11 checks passed
@CryptoKnightIOG CryptoKnightIOG deleted the ATL-6305-Fix-Credential-Processing branch January 3, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants