Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove Anoncred Prefix from AnoncredLib #890

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

CryptoKnightIOG
Copy link
Contributor

@CryptoKnightIOG CryptoKnightIOG commented Feb 9, 2024

Overview

Fixes https://input-output.atlassian.net/browse/ATL-6566

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

Signed-off-by: Bassam Riman <bassam.riman@iohk.io>
Signed-off-by: Bassam Riman <bassam.riman@iohk.io>
@CryptoKnightIOG CryptoKnightIOG changed the base branch from main to feat/ZKP-verification February 9, 2024 14:37
@CryptoKnightIOG CryptoKnightIOG marked this pull request as ready for review February 9, 2024 14:37
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Integration Test Results

12 files  ±0  12 suites  ±0   2s ⏱️ ±0s
25 tests ±0  25 ✅ ±0  0 💤 ±0  0 ❌ ±0 
26 runs  ±0  26 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2f03f8e. ± Comparison against base commit 55c8331.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 9, 2024

Unit Test Results

 88 files  ±0   88 suites  ±0   19m 57s ⏱️ -41s
737 tests ±0  729 ✅ ±0  8 💤 ±0  0 ❌ ±0 
745 runs  ±0  737 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 2f03f8e. ± Comparison against base commit 55c8331.

♻️ This comment has been updated with latest results.

Signed-off-by: Bassam Riman <bassam.riman@iohk.io>
Copy link
Member

@yshyn-iohk yshyn-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refactoring, @CryptoKnightIOG!

Signed-off-by: Bassam Riman <bassam.riman@iohk.io>
Copy link

Quality Gate Passed Quality Gate passed

Issues
52 New issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

@CryptoKnightIOG CryptoKnightIOG merged commit cffa3bc into feat/ZKP-verification Feb 14, 2024
11 checks passed
@CryptoKnightIOG CryptoKnightIOG deleted the ATL-XXXX-Refactor branch February 14, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants