-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: enhancements + vault token test #924
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amagyar-iohk
force-pushed
the
tests/vault-token
branch
from
March 11, 2024 14:41
eb4ef8f
to
871a9f5
Compare
amagyar-iohk
requested review from
yshyn-iohk,
patlo-iog and
mineme0110
as code owners
March 11, 2024 15:29
patlo-iog
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Ran the ./gradlew regression
and everything was green.
amagyar-iohk
force-pushed
the
tests/vault-token
branch
2 times, most recently
from
March 13, 2024 19:19
9394378
to
871a9f5
Compare
vault approle finish Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
amagyar-iohk
force-pushed
the
tests/vault-token
branch
from
March 13, 2024 19:19
871a9f5
to
4ccfbe3
Compare
Quality Gate passedIssues Measures |
shotexa
pushed a commit
that referenced
this pull request
Mar 18, 2024
Signed-off-by: Allain Magyar <allain.magyar@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa
pushed a commit
that referenced
this pull request
Mar 18, 2024
Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
shotexa
pushed a commit
that referenced
this pull request
Mar 18, 2024
Signed-off-by: Allain Magyar <allain.magyar@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa
pushed a commit
that referenced
this pull request
Mar 18, 2024
Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
shotexa
pushed a commit
that referenced
this pull request
Mar 18, 2024
Signed-off-by: Allain Magyar <allain.magyar@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa
pushed a commit
that referenced
this pull request
Mar 18, 2024
Signed-off-by: Allain Magyar <allain.magyar@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa
pushed a commit
that referenced
this pull request
Mar 18, 2024
Signed-off-by: Allain Magyar <allain.magyar@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa
pushed a commit
that referenced
this pull request
Mar 18, 2024
Signed-off-by: Allain Magyar <allain.magyar@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa
pushed a commit
that referenced
this pull request
Mar 18, 2024
Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updated integration tests
./gradlew test_basic
Alternatives Considered (optional):
Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas.
Checklist: