Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enhancements + vault token test #924

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

amagyar-iohk
Copy link
Contributor

Description:

Updated integration tests

  • Vault token scenario added
  • Added gradle tasks for each config available
    • e.g. ./gradlew test_basic
  • Updated ktlint + format (many files changes due that)

Alternatives Considered (optional):

Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Copy link
Contributor

github-actions bot commented Mar 11, 2024

Integration Test Results

12 files  ±0  12 suites  ±0   2s ⏱️ ±0s
25 tests ±0  25 ✅ ±0  0 💤 ±0  0 ❌ ±0 
26 runs  ±0  26 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4ccfbe3. ± Comparison against base commit 27a157f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 11, 2024

Unit Test Results

 88 files  ±0   88 suites  ±0   20m 21s ⏱️ -14s
761 tests ±0  753 ✅ ±0  8 💤 ±0  0 ❌ ±0 
768 runs  ±0  760 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 4ccfbe3. ± Comparison against base commit 27a157f.

♻️ This comment has been updated with latest results.

@amagyar-iohk amagyar-iohk marked this pull request as ready for review March 11, 2024 15:29
Copy link
Contributor

@patlo-iog patlo-iog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ran the ./gradlew regression and everything was green.

@amagyar-iohk amagyar-iohk force-pushed the tests/vault-token branch 2 times, most recently from 9394378 to 871a9f5 Compare March 13, 2024 19:19
vault approle finish

Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
Copy link

Quality Gate Passed Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.4% Duplication on New Code

See analysis details on SonarCloud

@amagyar-iohk amagyar-iohk merged commit 7163c94 into main Mar 14, 2024
11 checks passed
@amagyar-iohk amagyar-iohk deleted the tests/vault-token branch March 14, 2024 10:38
shotexa pushed a commit that referenced this pull request Mar 18, 2024
Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
Signed-off-by: Allain Magyar <allain.magyar@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants